-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🎉Source Google Ads: Updated API version from v9 to v11 #14614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test connector=connectors/source-google-ads
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find all "v9" appearances and replace them with the actual version. There's a bunch of imports and an URL in spec.json containing the api version
/publish connector=connectors/source-google-ads
if you have connectors that successfully published but failed definition generation, follow step 4 here
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
#14384 - API v9 is deprecated and was updated to v11
How
Updated few schema fields, version variable and docs.
Pre-merge Checklist
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here