feat: move serviceType selection out of serviceForm #14526
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
harshithmullapudi
force-pushed
the
harshith/serviceType-fix
branch
from
90dd7a5 to
70ee071
Compare
|
We took this to solve within the team and it's been resolved by #17597 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
While I was building this feature, I had a problem: #14462 that the name is not taken from initialValues for formik.
I think the proper fix here would be to move the serviceType selection out of formik and move it into the parent component thus should avoid a lot of rerenders and multiple handlers.
This is just a quick take on how that could look like
Screen.Recording.2022-07-08.at.2.25.29.PM.mov