-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Destination Databricks : Allow Incremental Deduped sync #14445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination Databricks : Allow Incremental Deduped sync #14445
Conversation
@tuliren, sent you an invite for collaboration :) |
…ingers/destination-databricks-normalizable
…rodingers/destination-databricks-normalizable
…rodingers/destination-databricks-normalizable
EC2 Default User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Hello @shrodingers Liren is actively working in the Databricks destination and will return to your contribution in the future. |
Hello @marcosmarxm ! Thanks for the update, that's good news ! While running these changes as a separate custom connector, I stumbled upon some issues / some whereabouts so at the time this will be considered, i'll be more than happy to help and discuss pros and cons of these changes. |
I glanced through the FE changes and it looks like airbyte-webapp was hit with a linter it shouldn't be. Unsure if there were actual FE changes but what I did see was simply linting changes that should be pulled out. |
Hello 👋, first thank you for this amazing contribution. We really appreciate the effort you've made to improve the project. If you have any questions feel free to send me a message in Slack! |
Hello @krishnaglick, @marcosmarxm ! |
Hello 👋:skin-tone-2: and thank you for your contribution! Airbyte has instituted a code freeze between 19 and 30 December, to make sure there are no disruptions during the holidays. If you have any questions or need further clarification, please don't hesitate to ping via Slack. |
Hey, @shrodingers! It looks like the best course of action is to split this PR up into smaller ones and refactor it. As you yourself mention that it is not mergeable, I'm closing it for now. |
What
Enables the incremental deduped sync on databricks connector
How
Recommended reading order
dbt added macros / models
normalization updates
connector updates
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
There are breaking changes, since it totally modifies the way data is stored through the connector (may be a good idea to separate this connector from the original one to be not breaking)
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.