Remove legacy sentry code from java connectors #14414

Phlair · 2022-07-05T14:41:54Z

What

java connector part of #13335

How

Removing code.
I'm not planning to publish new versions of the connectors with this PR as i'm just removing redundant code.

Phlair · 2022-07-05T14:44:24Z

@tuliren I'd appreciate you checking over this as I'm not 100% sure on whether the syntax needs to change in some places when removing the executeWithTracing()

grishick · 2022-07-14T20:52:17Z

Looks good. Please run integration tests for each of the affected connectors

Phlair · 2022-07-19T14:21:44Z

/test connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/2698332751
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/2698332751
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:21:50Z

/test connector=connectors/destination-oracle-strict-encrypt

🕑 connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2698333171
✅ connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2698333171
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:21:57Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/2698334828
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/2698334828
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:22:12Z

/test connector=connectors/destination-databricks

🕑 connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/2698335439
✅ connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/2698335439
No Python unittests run

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:22:51Z

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2698339944
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2698339944
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:24:06Z

/test connector=connectors/destination-mssql-strict-encrypt

🕑 connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2698347929
✅ connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2698347929
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:24:46Z

/test connector=connectors/destination-oracle-strict-encrypt

🕑 connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2698353026
✅ connectors/destination-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2698353026
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:26:08Z

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2698362934
✅ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/2698362934
No Python unittests run

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:26:13Z

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2698362815
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2698362815
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:26:39Z

/test connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/2698365789
✅ connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/2698365789
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

Phlair · 2022-07-19T14:26:54Z

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2698367628
✅ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2698367628
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

…emove-legacy-sentry-java

Phlair · 2022-07-19T17:30:39Z

@grishick tests all looking good, you ok to approve?

* remove a bunch of things * removed the rest * formatting

Phlair added 3 commits June 24, 2022 11:21

remove a bunch of things

3cb82f1

Merge branch 'master' into george/remove-legacy-sentry-java

6b0772e

removed the rest

b8190c1

github-actions bot added the area/connectors Connector related issues label Jul 5, 2022

octavia-squidington-iii added connectors/destination/snowflake connectors/destination/redshift connectors/destination/s3 connectors/destination/jdbc connectors/source/e2e-test labels Jul 5, 2022

Phlair self-assigned this Jul 5, 2022

Phlair requested a review from tuliren July 5, 2022 14:42

Phlair mentioned this pull request Jul 5, 2022

Turn off any legacy unused Sentry connector instrumentation #13335

Closed

2 tasks

Phlair requested a review from a team July 14, 2022 17:06

Merge commit 'd1447eb8d26f170b39b3a5814129b2c3736d3882' into george/r…

9d5eb8c

…emove-legacy-sentry-java

grishick approved these changes Jul 19, 2022

View reviewed changes

Merge branch 'master' into george/remove-legacy-sentry-java

7a2fd2c

formatting

e097d84

Phlair merged commit e88db76 into master Jul 20, 2022

Phlair deleted the george/remove-legacy-sentry-java branch July 20, 2022 11:30

mfsiega-airbyte pushed a commit that referenced this pull request Jul 21, 2022

Remove legacy sentry code from java connectors (#14414)

3c13e71

* remove a bunch of things * removed the rest * formatting

octavia-squidington-iii mentioned this pull request Jul 23, 2022

Bump Airbyte version from 0.39.37-alpha to 0.39.38-alpha #14976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove legacy sentry code from java connectors #14414

Remove legacy sentry code from java connectors #14414

Phlair commented Jul 5, 2022

Phlair commented Jul 5, 2022 •

edited

Loading

grishick commented Jul 14, 2022

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022

Remove legacy sentry code from java connectors #14414

Remove legacy sentry code from java connectors #14414

Conversation

Phlair commented Jul 5, 2022

What

How

Phlair commented Jul 5, 2022 • edited Loading

grishick commented Jul 14, 2022

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

Phlair commented Jul 19, 2022

Phlair commented Jul 5, 2022 •

edited

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading

Phlair commented Jul 19, 2022 •

edited by github-actions bot

Loading