🎉 Source Hubspot: Add private app authentication #14412

vladimir-remar · 2022-07-05T14:24:31Z

What

How

Add a TokenAuthenticator

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

harshithmullapudi · 2022-07-06T04:10:52Z

Hey @vladimir-remar thanks for the contribution. Couple of more steps and we are there. Here is documentation for updating an existing connector https://docs.airbyte.io/connector-development#updating-an-existing-connector

harshithmullapudi · 2022-07-06T09:31:40Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2621820633
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2621820633
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/helpers.py       70      3    96%
source_hubspot/streams.py      769     67    91%
source_hubspot/source.py        98     21    79%
------------------------------------------------
TOTAL                          945     91    90%

Build Passed

Test summary info:

All Passed

harshithmullapudi · 2022-07-08T04:35:07Z

airbyte-integrations/connectors/source-hubspot/source_hubspot/source.py

@@ -87,7 +87,8 @@ def get_common_params(self, config) -> Mapping[str, Any]:
        api = self.get_api(config=config)
        common_params = dict(api=api, start_date=start_date, credentials=credentials)

-        if credentials.get("credentials_title") == "OAuth Credentials":


can we create constants for 2 strings and use them instead?

harshithmullapudi · 2022-07-11T05:49:15Z

Hey @vladimir-remar could you look at that one small change?

vladimir-remar · 2022-07-11T06:44:39Z

Hey @vladimir-remar could you look at that one small change?

Thanks for your patience, I will check it ASAP.

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py

vladimir-remar · 2022-07-14T07:02:55Z

@harshithmullapudi could you take a look on this and let me know if there is something new to update?

bjgbeelen · 2022-07-14T07:43:02Z

@vladimir-remar I see the branch has conflicts again, that's something to already resolve perhaps for smooth merging soon

vladimir-remar · 2022-07-14T08:19:26Z

@vladimir-remar I see the branch has conflicts again, that's something to already resolve perhaps for smooth merging soon

@bjgbeelen @harshithmullapudi conflicts already fixed

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py

harshithmullapudi · 2022-07-15T09:43:30Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2676019937
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2676019937
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       772     68    91%
source_hubspot/source.py         99     21    79%
-------------------------------------------------
TOTAL                           952     92    90%

Build Passed

Test summary info:

All Passed

harshithmullapudi · 2022-07-15T12:28:35Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2676840831
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2676840831
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       772     68    91%
source_hubspot/source.py         99     21    79%
-------------------------------------------------
TOTAL                           952     92    90%

Build Passed

Test summary info:

All Passed

harshithmullapudi · 2022-07-17T10:45:00Z

/publish connector=connectors/source-hubspot

🕑 Publishing the following connectors:
connectors/source-hubspot
https://github.com/airbytehq/airbyte/actions/runs/2685196861

Connector	Did it publish?	Were definitions generated?
connectors/source-hubspot	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…b.com:vladimir-remar/airbyte into source-hubspot-add-private-app-authentication

optical · 2022-08-03T03:47:36Z

Hi folks, apologies if this isn't the correct place for this question. Looking at using the Private App authentication here, but I'm unsure of exactly which Private App scopes are required by the integration? It looks like they're different to the oauth scopes that are well documented in the Airbyte Hubspot connector docs

mranawake · 2022-08-03T15:29:47Z

I second @optical suggestion, best if the team update the docs at https://docs.airbyte.com/integrations/sources/hubspot/ and include a 3rd column outlining private app scopes.

add new authentication method

e09e81b

octavia-squidington-iii added bounty community connectors/source/hubspot labels Jul 5, 2022

github-actions bot added the area/connectors Connector related issues label Jul 5, 2022

marcosmarxm changed the title ~~🎉Add private app authentication~~ 🎉 Source Hubspot: Add private app authentication Jul 5, 2022

harshithmullapudi self-requested a review July 6, 2022 04:10

harshithmullapudi self-assigned this Jul 6, 2022

update connector version in Dockerfile and hubspot.md

2707c09

github-actions bot added the area/documentation Improvements or additions to documentation label Jul 6, 2022

harshithmullapudi reviewed Jul 8, 2022

View reviewed changes

vladimir-remar added 2 commits July 11, 2022 08:46

Merge branch 'master' into source-hubspot-add-private-app-authentication

e3050cb

update: check credentials title through constants

06739b4

bjgbeelen reviewed Jul 11, 2022

View reviewed changes

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py Outdated Show resolved Hide resolved

vladimir-remar added 2 commits July 11, 2022 17:12

add constant file for credentials title values

8aacd74

Merge branch 'master' into source-hubspot-add-private-app-authentication

eb0caed

vladimir-remar requested a review from harshithmullapudi July 14, 2022 06:58

vladimir-remar added 2 commits July 14, 2022 09:58

fix conflicts

32c004d

update dockerfile

11cfe83

faacsousa reviewed Jul 14, 2022

View reviewed changes

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py Outdated Show resolved Hide resolved

add 'API Key Credentials' to constants

444dc45

chore: added connector to definitions

4bb9de2

octavia-squidington-iii and others added 3 commits July 17, 2022 11:04

auto-bump connector version

0aa43be

chore: formatting

9751326

Merge branch 'source-hubspot-add-private-app-authentication' of githu…

a0ac5fc

…b.com:vladimir-remar/airbyte into source-hubspot-add-private-app-authentication

harshithmullapudi merged commit 2b7a12b into airbytehq:master Jul 17, 2022

octavia-squidington-iii mentioned this pull request Jul 23, 2022

Bump Airbyte version from 0.39.37-alpha to 0.39.38-alpha #14976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Hubspot: Add private app authentication #14412

🎉 Source Hubspot: Add private app authentication #14412

vladimir-remar commented Jul 5, 2022

harshithmullapudi commented Jul 6, 2022

harshithmullapudi commented Jul 6, 2022 •

edited by github-actions bot

Loading

harshithmullapudi Jul 8, 2022

harshithmullapudi commented Jul 11, 2022

vladimir-remar commented Jul 11, 2022 •

edited

Loading

vladimir-remar commented Jul 14, 2022

bjgbeelen commented Jul 14, 2022

vladimir-remar commented Jul 14, 2022

harshithmullapudi commented Jul 15, 2022 •

edited by github-actions bot

Loading

harshithmullapudi commented Jul 15, 2022 •

edited by github-actions bot

Loading

harshithmullapudi commented Jul 17, 2022 •

edited by github-actions bot

Loading

optical commented Aug 3, 2022

mranawake commented Aug 3, 2022

🎉 Source Hubspot: Add private app authentication #14412

🎉 Source Hubspot: Add private app authentication #14412

Conversation

vladimir-remar commented Jul 5, 2022

What

How

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

harshithmullapudi commented Jul 6, 2022

harshithmullapudi commented Jul 6, 2022 • edited by github-actions bot Loading

Build Passed

harshithmullapudi Jul 8, 2022

Choose a reason for hiding this comment

harshithmullapudi commented Jul 11, 2022

vladimir-remar commented Jul 11, 2022 • edited Loading

vladimir-remar commented Jul 14, 2022

bjgbeelen commented Jul 14, 2022

vladimir-remar commented Jul 14, 2022

harshithmullapudi commented Jul 15, 2022 • edited by github-actions bot Loading

Build Passed

harshithmullapudi commented Jul 15, 2022 • edited by github-actions bot Loading

Build Passed

harshithmullapudi commented Jul 17, 2022 • edited by github-actions bot Loading

optical commented Aug 3, 2022

mranawake commented Aug 3, 2022

harshithmullapudi commented Jul 6, 2022 •

edited by github-actions bot

Loading

vladimir-remar commented Jul 11, 2022 •

edited

Loading

harshithmullapudi commented Jul 15, 2022 •

edited by github-actions bot

Loading

harshithmullapudi commented Jul 15, 2022 •

edited by github-actions bot

Loading

harshithmullapudi commented Jul 17, 2022 •

edited by github-actions bot

Loading