Skip to content

Adds delete button for adding email form #14296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2022
Merged

Adds delete button for adding email form #14296

merged 2 commits into from
Jul 18, 2022

Conversation

YatsukBogdan1
Copy link
Contributor

What

Closes #13456

How

I decided that the best decision from a UX point of view would be to add simple delete buttons on each new email row, so if some emails are unnecessary user can simply remove them

Loom

https://www.loom.com/share/b042b9b9bfd34ecf88c23973f6e7fd44

@YatsukBogdan1 YatsukBogdan1 requested a review from a team as a code owner June 30, 2022 11:20
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Jun 30, 2022
teallarson
teallarson reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I think it's fine to leave as a styled component for the small change.

I believe the build failure you're having may be just needing to run the linter

dizel852
dizel852 approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - no issues.
LGTM 👍

Nitpicking: since we are making changes to <InviteUsersModal /> component would be great to fix that annoying "react unique key" warning also, just to have it polished 🙂

image

@YatsukBogdan1 YatsukBogdan1 merged commit 89530b0 into master Jul 18, 2022
@YatsukBogdan1 YatsukBogdan1 deleted the byatsuk/feature-improve-adding-user-usability branch July 18, 2022 19:47
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teallarson teallarson teallarson left review comments

@dizel852 dizel852 dizel852 approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve usability of email invite form
3 participants
@YatsukBogdan1 @dizel852 @teallarson