[Github Actions] Rename docker secrets and parameterize docker user #13297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
changed the title
pedroslopez
reviewed
May 28, 2022
| @@ -44,7 +44,7 @@ function findAndDeleteTag () { | |||
| } | |||
|
|
|||
| function cleanUpImages () { | |||
| TOKEN=$(curl --request POST 'https://hub.docker.com/v2/users/login/' --header 'Content-Type: application/json' --data-raw '{"username":"airbytebot","password":"'$DOCKER_PASSWORD'"}' | jq '.token') | |||
| TOKEN=$(curl --request POST 'https://hub.docker.com/v2/users/login/' --header 'Content-Type: application/json' --data-raw '{"username":"'$DOCKER_HUB_USERNAME'","password":"'$DOCKER_HUB_PASSWORD'"}' | jq '.token') | |||
There was a problem hiding this comment.
hmm - this one is also grabbing a token through curl, do we need to set +x set -x here as well?
There was a problem hiding this comment.
I don't think so, because no where in the file do we turn that on (set +x)?
There was a problem hiding this comment.
... but maybe we should?
There was a problem hiding this comment.
Ah! I see, it was specifically enabled on manage.sh - should be ok then
cgardens
approved these changes
May 28, 2022
pedroslopez
reviewed
May 28, 2022
Co-authored-by: Pedro S. Lopez <[email protected]>
pedroslopez
approved these changes
May 28, 2022
jscottpolevault
pushed a commit
to jscottpolevault/airbyte
that referenced
this pull request
Jun 1, 2022
…irbytehq#13297) * Rename docker secrets and parameterize docker user * Apply suggestions from code review Co-authored-by: Pedro S. Lopez <[email protected]> Co-authored-by: Pedro S. Lopez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/airbytehq/airbyte-cloud/issues/1763
This PR renames the secrets so that old branches stop working and folks will need to rebase from master to publish from here on out. I also require a secret for the docker username.
Note: DO NOT update the secrets until this PR is merged to master!