Skip to content

🐛 Destination BigQuery Denormalized : fix datetime with timezone #13286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2022
Merged

🐛 Destination BigQuery Denormalized : fix datetime with timezone #13286

merged 6 commits into from
May 30, 2022

Conversation

DoNotPanicUA
Copy link
Contributor

@DoNotPanicUA DoNotPanicUA commented May 27, 2022 •
edited
Loading

What

Issue #13229

In addition, enable Basic and Object the new DATs.

Recommended reading order

  1. BigQueryDenormalizedDestinationAcceptanceTest.java
  2. BigQueryDenormalizedTestDataComparator.java

@github-actions github-actions bot added the area/connectors Connector related issues label May 27, 2022
@DoNotPanicUA DoNotPanicUA force-pushed the aleonets/DAT-bigquery-denorm branch from e6104bc to 3528645 Compare May 27, 2022 16:58
@DoNotPanicUA

This comment was marked as outdated.

Sign in to view
@DoNotPanicUA DoNotPanicUA marked this pull request as ready for review May 27, 2022 17:04
@DoNotPanicUA DoNotPanicUA self-assigned this May 27, 2022
@DoNotPanicUA

This comment was marked as off-topic.

Sign in to view
@DoNotPanicUA DoNotPanicUA linked an issue May 28, 2022 that may be closed by this pull request
🐛 Destination BigQuery Denormalized : lose timezone after insert datetime with TZ #13229
Closed
@DoNotPanicUA

This comment was marked as outdated.

Sign in to view
@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented May 30, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2408933849
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2408933849
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%

Build Passed

Test summary info:

All Passed

@DoNotPanicUA DoNotPanicUA merged commit 2351396 into master May 30, 2022
@DoNotPanicUA DoNotPanicUA deleted the aleonets/DAT-bigquery-denorm branch May 30, 2022 13:28
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 31, 2022
Merged
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
@DoNotPanicUA
🐛 Destination BigQuery Denormalized : fix datetime with timezone (air…
5be1aa4 
…bytehq#13286)

* Enable DAT

* google format

* handle DateTime with Timezone as Timestamp

* format

* disable "old date" case due to known BigQuery issue

* disable array test case due to known BigQuery issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashaNeshcheret sashaNeshcheret sashaNeshcheret approved these changes

@alexandr-shegeda alexandr-shegeda Awaiting requested review from alexandr-shegeda

Assignees

@DoNotPanicUA DoNotPanicUA

Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Destination BigQuery Denormalized : lose timezone after insert datetime with TZ
2 participants
@DoNotPanicUA @sashaNeshcheret