Skip to content

🎉 Python CDK: handle requests.exceptions.ChunkedEncodingError for broken connections #13260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2022
Merged

🎉 Python CDK: handle requests.exceptions.ChunkedEncodingError for broken connections #13260

merged 4 commits into from
May 27, 2022

Conversation

davydov-d
Copy link
Collaborator

What

According to this ticket, the requests.exceptions.ChunckedEncodingError is not handled, though it probably should be. Now fixing it in airbyte-cdk

@github-actions github-actions bot added the CDK Connector Development Kit label May 27, 2022
bazarnov
bazarnov requested changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG.md should also be updated
https://github.com/airbytehq/airbyte/blob/ddavydov/%2312591-retry-chunked-encoding-error-in-cdk/airbyte-cdk/python/CHANGELOG.md

@bazarnov bazarnov changed the title CDK: retry exceptions.ChunkedEncodingError 🎉 Python CDK: handle requests.exceptions.ChunkedEncodingError for broken connections May 27, 2022
@davydov-d
Copy link
Collaborator Author

The CHANGELOG.md should also be updated https://github.com/airbytehq/airbyte/blob/ddavydov/%2312591-retry-chunked-encoding-error-in-cdk/airbyte-cdk/python/CHANGELOG.md

thanks, done

@davydov-d davydov-d requested a review from bazarnov May 27, 2022 11:28
@bazarnov
Copy link
Collaborator

bazarnov commented May 27, 2022 •
edited by github-actions bot
Loading

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/2396409372
✅ https://github.com/airbytehq/airbyte/actions/runs/2396409372

@bazarnov bazarnov requested a review from evantahler May 27, 2022 12:12
evantahler
evantahler approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bazarnov
Copy link
Collaborator

bazarnov commented May 27, 2022 •
edited by github-actions bot
Loading

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/2398234785
✅ https://github.com/airbytehq/airbyte/actions/runs/2398234785

@bazarnov bazarnov merged commit acd1533 into master May 27, 2022
@bazarnov bazarnov deleted the ddavydov/#12591-retry-chunked-encoding-error-in-cdk branch May 27, 2022 19:05
@github-actions github-actions bot added the area/connectors Connector related issues label May 27, 2022
@lazebnyi lazebnyi removed their request for review May 30, 2022 10:53
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 31, 2022
Merged
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
@davydov-d
🎉 Python CDK: handle requests.exceptions.ChunkedEncodingError for b…
c4bb9c3 
…roken connections (airbytehq#13260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

@bazarnov bazarnov bazarnov approved these changes

@grubberr grubberr Awaiting requested review from grubberr

Assignees
No one assigned
Labels
area/connectors Connector related issues CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davydov-d @bazarnov @evantahler