🐛 Source HubSpot: Transform `contact_lists` data to comply with schema #13218

grubberr · 2022-05-26T09:10:18Z

Signed-off-by: Sergey Chvalyuk [email protected]

What

python3 main.py read --config secrets/config.json --catalog catalog.json.contact_lists | grep RECORD \
| jq '.record.data.filters[][].value | type' | sort | uniq -c
      4 "boolean"
    605 "null"
    131 "number"
    383 "string"

We can see that field contact_lists.filters[][].value can be a json multi-type

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-05-26T09:14:22Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2389778273
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2389778273
🐛 https://gradle.com/s/eqeaotgzmazfy

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - Failed: Please check...
=================== 2 failed, 28 passed in 187.17s (0:03:07) ===================

codecov · 2022-05-26T09:18:27Z

Codecov Report

❗ No coverage uploaded for pull request base (master@d0d74ec). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13218   +/-   ##
=========================================
  Coverage          ?   91.00%           
=========================================
  Files             ?        4           
  Lines             ?      812           
  Branches          ?        0           
=========================================
  Hits              ?      739           
  Misses            ?       73           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d74ec...5bc42d3. Read the comment docs.

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-05-27T08:28:48Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2395428703
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2395428703
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/streams.py      714     61    91%
source_hubspot/source.py        87     25    71%
------------------------------------------------
TOTAL                          809     86    89%

Build Passed

Test summary info:

All Passed

airbyte-integrations/connectors/source-hubspot/source_hubspot/schemas/contact_lists.json

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2022-06-02T18:14:29Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2430074186
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2430074186
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/streams.py      727     56    92%
source_hubspot/source.py        77     17    78%
------------------------------------------------
TOTAL                          812     73    91%

Build Passed

Test summary info:

All Passed

grubberr · 2022-06-02T18:59:12Z

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2430293353
🚀 Successfully published connectors/source-hubspot
🚀 Auto-bumped version for connectors/source-hubspot
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2430293353

* master: (142 commits) Highlight removed and added streams in Connection form (airbytehq#13392) 🐛 Source Amplitude: Fixed JSON Validator `date-time` validation (airbytehq#13373) 🐛 Source Mixpanel: publish v0.1.17 (airbytehq#13450) Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements (airbytehq#13388) 🎉 Source Freshdesk: Added new streams (airbytehq#13332) Prepare YamlSeedConfigPersistence for dependency injection (airbytehq#13384) helm chart: Support nodeSelector, tolerations and affinity on the booloader pod (airbytehq#11467) airbyte-api: add jackson model annotations to remove null values from responses (airbytehq#13370) Change stage to `beta` (airbytehq#13422) 🐛 Source Google Sheets: Retry on server errors (airbytehq#13446) Improve kube deploy process. (airbytehq#13397) Helm chart dependencies fix (airbytehq#13432) 🐛 Source HubSpot: Transform `contact_lists` data to comply with schema (airbytehq#13218) airbytehq#11758: Source Google Ads to GA (airbytehq#13441) Add more pr actions to tag pull requests (airbytehq#13437) Source Google Ads: drop schema field that filters out the data from stream (airbytehq#13423) Updates error view with new design (airbytehq#13197) Source MSSQL: correct enum Standard method (airbytehq#13419) Update postgres doc about cdc publication (airbytehq#13433) run source acceptance tests against image built from branch (airbytehq#13401) ...

Correct schema for contact_lists stream

c59e999

Signed-off-by: Sergey Chvalyuk <[email protected]>

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 26, 2022

hubspot.md updated

a90348f

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr changed the title ~~🐛 Source Github: Correct schema for contact_lists stream~~ 🐛 Source Hubspot: Correct schema for contact_lists stream May 26, 2022

grubberr self-assigned this May 26, 2022

grubberr linked an issue May 26, 2022 that may be closed by this pull request

Source-HubSpot: value field in contact_lists/filters is dynamically typed, but spec says it's string #12269

Closed

grubberr added 4 commits May 26, 2022 12:34

bump year 2021 -> 2022

307bd77

Signed-off-by: Sergey Chvalyuk <[email protected]>

make "value" multi-type ["null", "string", "integer", "boolean"]

b2ac0c5

Signed-off-by: Sergey Chvalyuk <[email protected]>

is_simple_multi_property added

5f134ae

Signed-off-by: Sergey Chvalyuk <[email protected]>

normalization updated

d3918f5

Signed-off-by: Sergey Chvalyuk <[email protected]>

github-actions bot added area/platform issues related to the platform area/worker Related to worker normalization labels May 26, 2022

grubberr temporarily deployed to more-secrets May 26, 2022 10:43 Inactive

grubberr added 2 commits May 26, 2022 13:57

format fix

0e5388b

Signed-off-by: Sergey Chvalyuk <[email protected]>

normalization 0.2.1 -> 0.2.2

20f0485

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr temporarily deployed to more-secrets May 26, 2022 11:00 Inactive

grubberr added 2 commits May 27, 2022 11:02

Merge branch 'master' into grubberr/12269-source-hubspot

05ddf58

revert normalization

641570c

Signed-off-by: Sergey Chvalyuk <[email protected]>

github-actions bot removed area/worker Related to worker area/platform issues related to the platform normalization labels May 27, 2022

revert normalization (2)

e36ef3d

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr requested a review from lazebnyi May 27, 2022 08:44

lazebnyi requested changes May 30, 2022

View reviewed changes

airbyte-integrations/connectors/source-hubspot/source_hubspot/schemas/contact_lists.json Outdated Show resolved Hide resolved

Merge branch 'master' into grubberr/12269-source-hubspot

d3933a2

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr added 2 commits June 2, 2022 19:29

TypeTransformer added for contact_lists stream

313f6fe

Signed-off-by: Sergey Chvalyuk <[email protected]>

hubspot.md updated

dcbba8f

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr changed the title ~~🐛 Source Hubspot: Correct schema for contact_lists stream~~ 🐛 Source HubSpot: Transform contact_lists data to comply with schema Jun 2, 2022

test_contact_lists_transform added

0bd6e90

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr requested a review from lazebnyi June 2, 2022 18:11

lazebnyi approved these changes Jun 2, 2022

View reviewed changes

auto-bump connector version

5bc42d3

octavia-squidington-iii temporarily deployed to more-secrets June 2, 2022 19:21 Inactive

bleonard added the connectors/source/hubspot label Jun 2, 2022

grubberr merged commit 537c9ba into master Jun 2, 2022

grubberr deleted the grubberr/12269-source-hubspot branch June 2, 2022 20:07

octavia-squidington-iii mentioned this pull request Jun 3, 2022

Bump Airbyte version from 0.39.8-alpha to 0.39.9-alpha #13454

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🐛 Source HubSpot: Transform `contact_lists` data to comply with schema #13218

🐛 Source HubSpot: Transform `contact_lists` data to comply with schema #13218

Uh oh!

grubberr commented May 26, 2022 •

edited

Loading

Uh oh!

grubberr commented May 26, 2022 •

edited by github-actions bot

Loading

Uh oh!

codecov bot commented May 26, 2022 •

edited

Loading

Uh oh!

grubberr commented May 27, 2022 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

grubberr commented Jun 2, 2022 •

edited by github-actions bot

Loading

Uh oh!

grubberr commented Jun 2, 2022 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

🐛 Source HubSpot: Transform contact_lists data to comply with schema #13218

🐛 Source HubSpot: Transform contact_lists data to comply with schema #13218

Uh oh!

Conversation

grubberr commented May 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

Uh oh!

grubberr commented May 26, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Failed

Uh oh!

codecov bot commented May 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

grubberr commented May 27, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

Uh oh!

grubberr commented Jun 2, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

grubberr commented Jun 2, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

🐛 Source HubSpot: Transform `contact_lists` data to comply with schema #13218

🐛 Source HubSpot: Transform `contact_lists` data to comply with schema #13218

grubberr commented May 26, 2022 •

edited

Loading

grubberr commented May 26, 2022 •

edited by github-actions bot

Loading

codecov bot commented May 26, 2022 •

edited

Loading

grubberr commented May 27, 2022 •

edited by github-actions bot

Loading

grubberr commented Jun 2, 2022 •

edited by github-actions bot

Loading

grubberr commented Jun 2, 2022 •

edited by github-actions bot

Loading