Skip to content

Source Freshdesk publish new version to Docker hub #13158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Source Freshdesk publish new version to Docker hub #13158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ac9b53a
freshdesk empty commit to publish version to docker hub
brianjlai May 25, 2022
cd7de5e
freshdesk: fix the tests so we can publish an image
brianjlai May 26, 2022
00d80df
Merge branch 'master' into brian/publish_freshdesk
brianjlai May 27, 2022
209491e
update version and documentation
brianjlai May 27, 2022
f16316e
Merge branch 'master' into brian/publish_freshdesk
brianjlai May 28, 2022
3c9772d
Merge branch 'master' into brian/publish_freshdesk
brianjlai May 29, 2022
140685b
Merge branch 'master' into brian/publish_freshdesk
alafanechere May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-freshdesk/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_freshdesk ./source_freshdesk
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.11
LABEL io.airbyte.version=0.2.12
LABEL io.airbyte.name=airbyte/source-freshdesk
9 changes: 8 additions & 1 deletion airbyte-integrations/connectors/source-freshdesk/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,14 @@ tests:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
empty_streams: ["satisfaction_ratings", "tickets", "time_entries", "conversations"]
empty_streams:
[
"satisfaction_ratings",
"tickets",
"time_entries",
"conversations",
"skills",
]
incremental:
- config_path: "secrets/config.json"
future_state_path: "integration_tests/abnormal_state.json"
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/groups.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"type": "string"
},
"auto_ticket_assign": {
"type": ["string", "null"]
"type": ["integer", "null"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, how did you find these schema issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the test_core.test_read() test has a validate schema check which was failing during the SAT run above. So then just to double check I made the requests against the freshdesk API in postman and updated all the types accordingly.

}
}
}
22 changes: 17 additions & 5 deletions airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/tickets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,28 @@
"type": "object",
"properties": {
"cc_emails": {
"type": "array"
"type": ["array", "null"],
"items": {
"type": "string"
}
},
"fwd_emails": {
"type": "array"
"type": ["array", "null"],
"items": {
"type": "string"
}
},
"reply_cc_emails": {
"type": "array"
"type": ["array", "null"],
"items": {
"type": "string"
}
},
"ticket_cc_emails": {
"type": "array"
"type": ["array", "null"],
"items": {
"type": "string"
}
},
"fr_escalated": {
"type": "boolean"
Expand All @@ -33,7 +45,7 @@
"type": "integer"
},
"responder_id": {
"type": "integer"
"type": ["integer", "null"]
},
"source": {
"type": "integer"
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/freshdesk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Please read [How to find your API key](https://support.freshdesk.com/support/sol

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:-------------------------------------------------------------------------------|
| 0.2.12 | 2022-05-27 | [13158](https://github.com/airbytehq/airbyte/pull/13158) | Fix schema issues and get the connector into a working state |
| 0.2.11 | 2021-12-14 | [8682](https://github.com/airbytehq/airbyte/pull/8682) | Migrate to the CDK |
| 0.2.10 | 2021-12-06 | [8524](https://github.com/airbytehq/airbyte/pull/8524) | Update connector fields title/description |
| 0.2.9 | 2021-11-16 | [8017](https://github.com/airbytehq/airbyte/pull/8017) | Bugfix an issue that caused the connector not to sync more than 50000 contacts |
Expand Down