Skip to content

Source Google Ads: fix configured catalog #13149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented May 24, 2022

What

Fix of Google Ads configured catalog for acceptance tests
This partially resolves the issue with the failing build https://github.com/airbytehq/airbyte/actions/runs/2362841778. Another fix should be introduced in #13148

@github-actions github-actions bot added the area/connectors Connector related issues label May 24, 2022
@davydov-d davydov-d self-assigned this May 24, 2022
@davydov-d davydov-d linked an issue May 24, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@ab070a7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13149   +/-   ##
=========================================
  Coverage          ?   90.63%           
=========================================
  Files             ?        5           
  Lines             ?      363           
  Branches          ?        0           
=========================================
  Hits              ?      329           
  Misses            ?       34           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab070a7...96e72a4. Read the comment docs.

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 25, 2022

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2384574390
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2384574390
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               68     10    85%
source_google_ads/streams.py                 138     21    85%
source_google_ads/source.py                   80     27    66%
source_google_ads/custom_query_stream.py      75     50    33%
--------------------------------------------------------------
TOTAL                                        363    108    70%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/source.py                   80      3    96%
source_google_ads/streams.py                 138     11    92%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               68     14    79%
--------------------------------------------------------------
TOTAL                                        363     34    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 695.66s (0:11:35) ===================

@davydov-d davydov-d merged commit 5a4cb12 into master May 25, 2022
@davydov-d davydov-d deleted the ddavydov/#13145-source-google-ads-fix-configured-catalog branch May 25, 2022 13:58
@lazebnyi lazebnyi removed their request for review May 30, 2022 10:53
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Google Ads: build fails on integration tests
2 participants