Skip to content

Make publish command work with private repos by adding JWT into curl headers #13141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 24, 2022
Merged

Make publish command work with private repos by adding JWT into curl headers #13141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
53a6496
Make publish command work with private repos?
noahkawasaki-airbyte May 24, 2022
8324f89
Add in username temp
noahkawasaki-airbyte May 24, 2022
83dbc8d
auto-bump connector version
octavia-squidington-iii May 24, 2022
0ed748c
Merge branch 'noah/publish-docker-repo' of https://github.com/airbyte…
octavia-squidington-iii May 24, 2022
2b1fc6a
Fix airbyte/ part
noahkawasaki-airbyte May 24, 2022
d0fc00b
merge
noahkawasaki-airbyte May 24, 2022
2d4e2d2
reset other changes
noahkawasaki-airbyte May 24, 2022
6ded976
It works, undo
noahkawasaki-airbyte May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/publish-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,11 @@ jobs:
SENTRY_PROJECT: airbyte-connectors
- name: Publish ${{ github.event.inputs.connector }}
run: |
echo "$SPEC_CACHE_SERVICE_ACCOUNT_KEY" > spec_cache_key_file.json && docker login -u airbytebot -p ${DOCKER_PASSWORD}
echo "$SPEC_CACHE_SERVICE_ACCOUNT_KEY" > spec_cache_key_file.json && docker login -u ${DOCKER_USERNAME} -p ${DOCKER_PASSWORD}
./tools/integrations/manage.sh publish airbyte-integrations/${{ github.event.inputs.connector }} ${{ github.event.inputs.run-tests }} --publish_spec_to_cache
id: publish
env:
DOCKER_USERNAME: airbytebot
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
# Oracle expects this variable to be set. Although usually present, this is not set by default on Github virtual runners.
TZ: UTC
Expand Down
8 changes: 6 additions & 2 deletions tools/integrations/manage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,16 @@ cmd_publish() {
docker push "$versioned_image"
docker push "$latest_image"
fi

# Checking if the image was successfully registered on DockerHub
# see the description of this PR to understand why this is needed https://github.com/airbytehq/airbyte/pull/11654/
sleep 5

# To work for private repos we need a token as well
DOCKER_USERNAME=${DOCKER_USERNAME:-airbytebot}
DOCKER_TOKEN=$(curl -s -H "Content-Type: application/json" -X POST -d '{"username": "'${DOCKER_USERNAME}'", "password": "'${DOCKER_PASSWORD}'"}' https://hub.docker.com/v2/users/login/ | jq -r .token)
TAG_URL="https://hub.docker.com/v2/repositories/${image_name}/tags/${image_version}"
DOCKERHUB_RESPONSE_CODE=$(curl --silent --output /dev/null --write-out "%{http_code}" ${TAG_URL})
DOCKERHUB_RESPONSE_CODE=$(curl --silent --output /dev/null --write-out "%{http_code}" -H "Authorization: JWT ${DOCKER_TOKEN}" ${TAG_URL})
if [[ "${DOCKERHUB_RESPONSE_CODE}" == "404" ]]; then
echo "Tag ${image_version} was not registered on DockerHub for image ${image_name}, please try to bump the version again." && exit 1
fi
Expand Down