Cancel when running a delete #13092
Cancel when running a delete #13092
Conversation
github-actions
bot
added
area/platform
| @@ -700,6 +703,12 @@ private void deleteConnectionBeforeTerminatingTheWorkflow() { | |||
| * Set a job as cancel and continue to the next job if and continue as a reset if needed | |||
| */ | |||
| private void reportCancelledAndContinueWith(final boolean isReset, final ConnectionUpdaterInput connectionUpdaterInput) { | |||
| reportCancelled(isReset); | |||
| resetNewConnectionInput(connectionUpdaterInput); | |||
| prepareForNextRunAndContinueAsNew(connectionUpdaterInput); | |||
There was a problem hiding this comment.
Do any of these methods throw exceptions, particularly RuntimeException, as I know that we like to use that as a way to signal failures? If so, should this be in a try/finally block to allow one or two of these methods to still fire if the first one or two raises an exception?
There was a problem hiding this comment.
Most of the method are getter/setter so very unlikely to throw a RuntimeException. The method that can throw are run using runMandatoryActivity which catch any exception and set the job in quarantine.
There was a problem hiding this comment.
Does it sounds protected enough to you?
| @@ -122,6 +122,9 @@ public void run(final ConnectionUpdaterInput connectionUpdaterInput) throws Retr | |||
| } | |||
|
|
|||
| if (workflowState.isDeleted()) { | |||
| if (workflowState.isRunning()) { | |||
| reportCancelled(false); | |||
There was a problem hiding this comment.
nit: add a log message here indicating that we are cancelling the job due to deleting the connection
* Cancel when running a delete * Add log
What
We currently don't cancel a running job when we are deleting a connection.
This PR is cancelling a running job if it is getting deleted.
It is calling the existing cancel activity if the job is running before deleting the connection.