Skip to content

Harshith/test pr 12280 #13079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 23, 2022
Merged

Harshith/test pr 12280 #13079

merged 8 commits into from
May 23, 2022

Conversation

harshithmullapudi
Copy link
Contributor

What

closes #12280

@github-actions github-actions bot added the area/connectors Connector related issues label May 23, 2022
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 23, 2022

/test connector=source-typeform

🕑 source-typeform https://github.com/airbytehq/airbyte/actions/runs/2370223399
✅ source-typeform https://github.com/airbytehq/airbyte/actions/runs/2370223399
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_typeform/__init__.py       2      0   100%
source_typeform/source.py       143      7    95%
-------------------------------------------------
TOTAL                           145      7    95%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 21 passed, 1 skipped in 77.58s (0:01:17) ===================

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@2b90559). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13079   +/-   ##
=========================================
  Coverage          ?   95.17%           
=========================================
  Files             ?        2           
  Lines             ?      145           
  Branches          ?        0           
=========================================
  Hits              ?      138           
  Misses            ?        7           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b90559...a71eef3. Read the comment docs.

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 23, 2022

/publish connector=connectors/source-typeform auto-bump-version=false

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/2370299830
🚀 Successfully published connectors/source-typeform
✅ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/2370299830

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 23, 2022

/publish connector=connectors/source-typeform auto-bump-version=false

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/2370312258
❌ Failed to publish connectors/source-typeform

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label May 23, 2022
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 23, 2022 09:31 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 23, 2022

/publish connector=connectors/source-typeform auto-bump-version=false

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/2370413259
🚀 Successfully published connectors/source-typeform
✅ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/2370413259

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 23, 2022 09:50 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 23, 2022 10:01 Inactive
@alafanechere
Copy link
Contributor

@harshithmullapudi Why do you need to open a specific branch for running the test / publish? You can do this from the original PR branch now.

@harshithmullapudi
Copy link
Contributor Author

@alafanechere there were huge conflicts since it is an old repo. And I was restricted on certain actions over the repo

@harshithmullapudi harshithmullapudi merged commit 34cd942 into master May 23, 2022
@harshithmullapudi harshithmullapudi deleted the harshith/test-pr-12280 branch May 23, 2022 10:31
@alafanechere
Copy link
Contributor

What were the restrictions, @itaseskii fork is not open for push?
I think for tracking contributions and give credits to @itaseskii it'll be better to merge the original branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants