Skip to content

Show integration test results on the Action Summary #13072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2022
Merged

Conversation

bleonard
Copy link
Contributor

@bleonard bleonard commented May 21, 2022

What

Bubbling up errors on our integration test actions so we don't have to look through the logs.
Even just getting the name of the connector at the top level seems helpful.

Also making it so that we can report short summaries on Java connectors. Was previously only Python.

Examples:

  1. Python failing: https://github.com/airbytehq/airbyte/actions/runs/2361505767
  2. Python passing: https://github.com/airbytehq/airbyte/actions/runs/2361506689 (note: I fixed \n)
  3. Java failing: https://github.com/airbytehq/airbyte/actions/runs/2361508418
  4. Java passing: https://github.com/airbytehq/airbyte/actions/runs/2361612733 (note: I fixed \n)

Screen Shot 2022-05-20 at 7 18 42 PM

How

Used $GITHUB_STEP_SUMMARY as described here.

@@ -159,7 +159,7 @@ jobs:
body: |
> :white_check_mark: ${{github.event.inputs.connector}} https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
${{env.PYTHON_UNITTEST_COVERAGE_REPORT}}
> ${{env.PYTHON_SHORT_TEST_SUMMARY_INFO}}
> ${{env.TEST_SUMMARY_INFO}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed because we are using it for both languages now

@bleonard bleonard temporarily deployed to more-secrets May 21, 2022 02:21 Inactive
@bleonard bleonard temporarily deployed to more-secrets May 21, 2022 02:24 Inactive
@bleonard bleonard temporarily deployed to more-secrets May 21, 2022 02:24 Inactive
@bleonard bleonard changed the title Pytest markdown Show integration test results on the Action SUmmary May 21, 2022
@bleonard bleonard changed the title Show integration test results on the Action SUmmary Show integration test results on the Action Summary May 21, 2022
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! good call

Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I'll try to find time to work something out for the platform builds.

@bleonard bleonard merged commit e82e6fc into master May 23, 2022
@bleonard bleonard deleted the pytest-markdown branch May 23, 2022 18:23
@bleonard
Copy link
Contributor Author

bleonard commented May 23, 2022

/test source-airtable

Error: Required input 'connector' not provided

@bleonard
Copy link
Contributor Author

/test connector=connectors/source-airtable

@bleonard
Copy link
Contributor Author

/test connector=connectors/destination-snowflake

@bleonard
Copy link
Contributor Author

/test connector=connectors/source-amazon-ads

@bleonard
Copy link
Contributor Author

/test connector=connectors/destination-bigquery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants