🐛 Update Qualaroo Spec #13042

danieldiamond · 2022-05-19T22:06:42Z

What

Fix NULL objects in spec

2022-05-19 21:40:35 �[33mWARN�[m i.a.w.DefaultReplicationWorker(lambda$getReplicationRunnable$5):298 - Record schema validation failed. Errors: json schema validation failed when comparing the data to the json schema. 
Errors: $.nps: null found, object expected

How

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

python -m pytest unit_tests
Test session starts (platform: darwin, Python 3.9.12, pytest 6.2.4, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /Users/danieldiamond/repos/airbyte, configfile: pytest.ini
plugins: sugar-0.9.4, requests-mock-1.9.3, mock-3.7.0, timeout-1.4.2
collecting ...
airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_request_params ✓ 25% ██▌
airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_next_page_token ✓ 50% █████
airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_surveys_stream ✓ 75% ███████▌
airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_responses_stream ✓ 100% ██████████
======================================================= warnings summary =======================================================
airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py: 11 warnings
/Users/danieldiamond/.virtualenvs/airbyte/lib/python3.9/site-packages/airbyte_cdk/sources/streams/http/http.py:42: DeprecationWarning: Call to deprecated class NoAuth. (Set authenticator=None instead) -- Deprecated since version 0.1.20.
self._authenticator: HttpAuthenticator = NoAuth()

airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py: 11 warnings
/Users/danieldiamond/.virtualenvs/airbyte/lib/python3.9/site-packages/deprecated/classic.py:173: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.
return old_new1(cls, *args, **kwargs)

-- Docs: https://docs.pytest.org/en/stable/warnings.html

Results (0.29s):
4 passed

Integration

Task :airbyte-integrations:connectors:source-qualaroo:sourceAcceptanceTest
============================= test session starts ==============================
platform linux -- Python 3.7.11, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /test_input
plugins: sugar-0.9.4, timeout-1.4.2
collected 13 items / 1 skipped / 12 selected

test_core.py ............ [ 92%]
test_full_refresh.py . [100%]

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 13 passed, 1 skipped in 389.79s (0:06:29) ===================

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.

BUILD SUCCESSFUL in 8m 42s
48 actionable tasks: 35 executed, 13 up-to-date

Acceptance

Put your acceptance tests output here.

danieldiamond · 2022-05-19T22:12:03Z

airbyte-integrations/connectors/source-qualaroo/source_qualaroo/schemas/responses.json

    },
    "nps": {
-      "type": "object",
+      "type": ["null", "object"],


Can I remove this NPS object from the response.json and still be able to pull it from the _AIRBYTE_RAW_RESPONSES table?

No it won't add to raw if you remove from schema.

marcosmarxm · 2022-05-20T13:24:21Z

/test connector=connectors/source-qualaroo

🕑 connectors/source-qualaroo https://github.com/airbytehq/airbyte/actions/runs/2358537843
✅ connectors/source-qualaroo https://github.com/airbytehq/airbyte/actions/runs/2358537843
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_qualaroo/__init__.py       2      0   100%
source_qualaroo/source.py        86     25    71%
-------------------------------------------------
TOTAL                            88     25    72%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 21 passed, 1 skipped in 19.73s ========================

marcosmarxm · 2022-05-21T03:16:04Z

/publish connector=connectors/source-qualaroo

🕑 connectors/source-qualaroo https://github.com/airbytehq/airbyte/actions/runs/2361755334
🚀 Successfully published connectors/source-qualaroo
🚀 Auto-bumped version for connectors/source-qualaroo
✅ connectors/source-qualaroo https://github.com/airbytehq/airbyte/actions/runs/2361755334

danieldiamond added 2 commits May 20, 2022 08:01

Update spec

fece376

Update object null spec

78e6b8b

octavia-squidington-iii added the community label May 19, 2022

github-actions bot added the area/connectors Connector related issues label May 19, 2022

Bump Dockerfile version

de3c320

github-actions bot added the area/documentation Improvements or additions to documentation label May 19, 2022

danieldiamond commented May 19, 2022

View reviewed changes

alafanechere assigned marcosmarxm May 20, 2022

auto-bump connector version

eb81f73

marcosmarxm approved these changes May 21, 2022

View reviewed changes

marcosmarxm merged commit 153b264 into airbytehq:master May 23, 2022

octavia-squidington-iii mentioned this pull request May 25, 2022

Bump Airbyte version from 0.39.1-alpha to 0.39.2-alpha #13188

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Update Qualaroo Spec #13042

🐛 Update Qualaroo Spec #13042

danieldiamond commented May 19, 2022 •

edited

Loading

danieldiamond May 19, 2022 •

edited

Loading

marcosmarxm May 23, 2022

marcosmarxm commented May 20, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 21, 2022 •

edited by github-actions bot

Loading

🐛 Update Qualaroo Spec #13042

🐛 Update Qualaroo Spec #13042

Conversation

danieldiamond commented May 19, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

danieldiamond May 19, 2022 • edited Loading

Choose a reason for hiding this comment

marcosmarxm May 23, 2022

Choose a reason for hiding this comment

marcosmarxm commented May 20, 2022 • edited by github-actions bot Loading

marcosmarxm commented May 21, 2022 • edited by github-actions bot Loading

danieldiamond commented May 19, 2022 •

edited

Loading

danieldiamond May 19, 2022 •

edited

Loading

marcosmarxm commented May 20, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 21, 2022 •

edited by github-actions bot

Loading