Fixes Spotless and runs spotless #13040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zipped files with JSON extension made this task sad
supertopher
commented
May 19, 2022
| @@ -103,6 +103,7 @@ def createSpotlessTarget = { pattern -> | |||
| 'secrets', | |||
| 'charts', // Helm charts often have injected template strings that will fail general linting. Helm linting is done separately. | |||
| 'resources/seed/*_specs.yaml', // Do not remove - this is necessary to prevent diffs in our github workflows, as the file diff check runs between the Format step and the Build step, the latter of which generates the file. | |||
| 'airbyte-integrations/connectors/source-amplitude/unit_tests/api_data/zipped.json', // Zipped file presents as non-UTF-8 making spotless sad | |||
There was a problem hiding this comment.
dear reviewer this is the only line that isn't formatting only
There was a problem hiding this comment.
looks great
I wonder why we have such a file though lol
There was a problem hiding this comment.
yeah I didn't blame it, I'll ask whomever is the author
git-phu
approved these changes
May 19, 2022
| @@ -103,6 +103,7 @@ def createSpotlessTarget = { pattern -> | |||
| 'secrets', | |||
| 'charts', // Helm charts often have injected template strings that will fail general linting. Helm linting is done separately. | |||
| 'resources/seed/*_specs.yaml', // Do not remove - this is necessary to prevent diffs in our github workflows, as the file diff check runs between the Format step and the Build step, the latter of which generates the file. | |||
| 'airbyte-integrations/connectors/source-amplitude/unit_tests/api_data/zipped.json', // Zipped file presents as non-UTF-8 making spotless sad | |||
There was a problem hiding this comment.
looks great
I wonder why we have such a file though lol
|
We have some failing tests for connectors. I think these failures were pre-existing but I'm going to hold off committing to master until I've looked a little harder |
davinchia
approved these changes
May 20, 2022
ganpatagarwal
pushed a commit
to ganpatagarwal/airbyte
that referenced
this pull request
May 20, 2022
zipped files with JSON extension made this task sad
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
zipped files with JSON extension made this task sad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zipped files with JSON extension made this task sad
What
./gradlew buildfailed for me on:spotlessHow
there was a zip file with a .json extension. we ignore that file now
also ran spotless
this is the one line change fixing spotless the rest is formatting only