Skip to content

🎉Source Google Search Console: increase unit test coverage at least 90% #13037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lazebnyi
Copy link
Collaborator

What

#13036 - Source Google Search Console: increase unit test coverage at least 90%

How

Increased unit test coverage to 90%

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@lazebnyi lazebnyi temporarily deployed to more-secrets May 19, 2022 18:52 Inactive
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 19, 2022
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented May 19, 2022

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/2354012144
✅ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/2354012144
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                            Stmts   Miss  Cover
-----------------------------------------------------------------------------------
source_google_search_console/__init__.py                            2      0   100%
source_google_search_console/source.py                             37      3    92%
source_google_search_console/streams.py                           118     14    88%
source_google_search_console/service_account_authenticator.py      14      6    57%
-----------------------------------------------------------------------------------
TOTAL                                                             171     23    87%

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@bd07fce). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13037   +/-   ##
=========================================
  Coverage          ?   90.05%           
=========================================
  Files             ?        4           
  Lines             ?      171           
  Branches          ?        0           
=========================================
  Hits              ?      154           
  Misses            ?       17           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd07fce...dfbd0c3. Read the comment docs.

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented May 19, 2022

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/2354428507
✅ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/2354428507
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                            Stmts   Miss  Cover
-----------------------------------------------------------------------------------
source_google_search_console/__init__.py                            2      0   100%
source_google_search_console/streams.py                           118      8    93%
source_google_search_console/source.py                             37      3    92%
source_google_search_console/service_account_authenticator.py      14      6    57%
-----------------------------------------------------------------------------------
TOTAL                                                             171     17    90%

@lazebnyi lazebnyi temporarily deployed to more-secrets May 19, 2022 20:28 Inactive
@lazebnyi lazebnyi removed the request for review from grubberr May 23, 2022 10:46
@lazebnyi lazebnyi merged commit 3528985 into master May 23, 2022
@lazebnyi lazebnyi deleted the lazebnyi/13036-google-search-console-unit-test-coverage-to-90 branch May 23, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
3 participants