helm-chart: Add annotations on webapp service

[thomas-vl]

What

Added the possibility of creating annotations on the service in the helm chart.

How

Updated the helm chart to allow service annotations.

🚨 User Impact 🚨

There are no breaking changes you can still deploy without using annotations.

[CLAassistant]

All committers have signed the CLA.

[martimors]

Suggest using the automated readme generator for documenting your new value instead, see ci.sh

[alafanechere]

Suggested change

	{{- if .Values.webapp.service.annotations }}
	annotations:
	{{- include "common.tplvalues.render" (dict "value" .Values.webapp.service.annotations "context" $) | nindent 4 }}
	{{- end }}
	{{- with .Values.webapp.service.annotations }}
	annotations:
	{{- toYaml . | nindent 4 }}
	{{- end }}

Does something prevents you from following the same syntax as used in ingress.yaml to create indentations? I'd prefer both file to use the same syntax for consistency.

[alafanechere]

Thank you @thomas-vl for this contribution. Could you please share why you need annotations on your web app service?

[alafanechere]

Suggest using the automated readme generator for documenting your new value instead, see ci.sh

Thank you for the suggestion @dingobar , I run ./ci.sh update-docs on this branch (after installing readme-generator) but it's failing with the following error:

ERROR: Missing metadata for key: webapp.service.annotations.toto
/opt/homebrew/lib/node_modules/readme-generator-for-helm/lib/checker.js:92
    throw new Error('ERROR: Wrong metadata!');
    ^

Error: ERROR: Wrong metadata!
    at checkKeys (/opt/homebrew/lib/node_modules/readme-generator-for-helm/lib/checker.js:92:11)
    at getValuesSections (/opt/homebrew/lib/node_modules/readme-generator-for-helm/index.js:23:3)
    at runReadmeGenerator (/opt/homebrew/lib/node_modules/readme-generator-for-helm/index.js:45:20)
    at Object.<anonymous> (/opt/homebrew/lib/node_modules/readme-generator-for-helm/bin/index.js:21:1)

Do you know how to fix this? It looks related to how the annotations value was defined in values.yaml.

[alafanechere]

@thomas-vl are you ready to make the changes @dingobar and I suggested?

[alafanechere]

FYI I'll be off until next Monday, please bear with me if there's a delay reviewing your upcoming changes.

[thomas-vl]

Thank you @thomas-vl for this contribution. Could you please share why you need annotations on your web app service?

I run Airbyte on GKE and I need to annotate the service with the correct NEG so that the HTTPS Loadbalancer knows what endpoint to use.
I'm also very limited on time, I'll make the changes this week.

[alafanechere]

@thomas-vl I made the changes suggested by @dingobar and used the same jinja syntax as in ingress.yaml to render annotations from values.