Skip to content

added option for giving polling time when consuming records using kafka consumer #12903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2022
Merged

added option for giving polling time when consuming records using kafka consumer #12903

merged 2 commits into from
May 29, 2022

Conversation

tirth7777777
Copy link
Contributor

What

Added option for adding polling time when records are being consumed from Kafka consumer. Kafka consumer polling time is fixed in source-kafka

How

added polling_time in spec and added polling time as a variable in KafkaSource file

🚨 User Impact 🚨

User would be able to give polling time as input which is helpful in case when 100 ms is not enough time to collect records from kafka

@CLAassistant
Copy link

CLAassistant commented May 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label May 17, 2022
marcosmarxm
marcosmarxm approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tirth7777777 looks you need to sign the CLA, can you check it?

@marcosmarxm
Copy link
Member

marcosmarxm commented May 17, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-kafka

🕑 connectors/source-kafka https://github.com/airbytehq/airbyte/actions/runs/2340642037
✅ connectors/source-kafka https://github.com/airbytehq/airbyte/actions/runs/2340642037
No Python unittests run

@marcosmarxm marcosmarxm self-assigned this May 17, 2022
@tirth7777777
Copy link
Contributor Author

@marcosmarxm I have signed the CLA. Can you merge the pullrequest

@marcosmarxm
Copy link
Member

marcosmarxm commented May 29, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kafka auto-bump-version=false

🕑 connectors/source-kafka https://github.com/airbytehq/airbyte/actions/runs/2404954690
🚀 Successfully published connectors/source-kafka
✅ connectors/source-kafka https://github.com/airbytehq/airbyte/actions/runs/2404954690

@tirth7777777 tirth7777777 requested a review from a team as a code owner May 29, 2022 19:18
@marcosmarxm marcosmarxm removed the request for review from a team May 29, 2022 19:19
@github-actions github-actions bot added area/api Related to the api area/platform issues related to the platform area/protocol area/scheduler area/server area/worker Related to worker CDK Connector Development Kit normalization area/frontend Related to the Airbyte webapp labels May 29, 2022
@github-actions github-actions bot added area/documentation Improvements or additions to documentation and removed area/api Related to the api area/scheduler area/frontend Related to the Airbyte webapp area/server area/worker Related to worker area/protocol labels May 29, 2022
@github-actions github-actions bot removed CDK Connector Development Kit normalization area/platform issues related to the platform labels May 29, 2022
@marcosmarxm marcosmarxm merged commit 83b9b4f into airbytehq:master May 29, 2022
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 31, 2022
Merged
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
@tirth7777777 @marcosmarxm
Source Kafka: added option for giving polling time when consuming rec…
a995a14 
…ords using consumer (airbytehq#12903)

* added option for giving polling time using spec

* add doc and seed file

Co-authored-by: marcosmarxm <[email protected]>
@marcosmarxm marcosmarxm mentioned this pull request Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees

@marcosmarxm marcosmarxm

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tirth7777777 @CLAassistant @marcosmarxm @octavia-squidington-iii