Skip to content

PgLsn New Test Case for .toString() #12899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2022

Conversation

nahal99
Copy link
Contributor

@nahal99 nahal99 commented May 17, 2022

What

Created a new test case for the .toString() method in the PgLsn.java folder.

How

Used assert equal similar to the other test cases written.

Recommended reading order

  1. PgLsnTest.java
  2. PgLsn.java

Tests

Unit

Put your unit tests output here.
Screen Shot 2022-05-16 at 11 34 16 PM
Screen Shot 2022-05-16 at 11 34 01 PM
Screen Shot 2022-05-16 at 11 34 30 PM

@alafanechere alafanechere self-assigned this May 20, 2022
@alafanechere alafanechere mentioned this pull request May 23, 2022
@alafanechere alafanechere temporarily deployed to more-secrets May 23, 2022 12:56 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets May 23, 2022 12:56 Inactive
@alafanechere
Copy link
Contributor

Thank you @nahal99 for this contrib. I'm running the CI tests on #13087 . If they pass I'll ask for a final review from the database connector team.

Copy link
Contributor

@grishick grishick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@grishick grishick merged commit 8b9fa33 into airbytehq:master May 23, 2022
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
* PgLsn New Test Case for .toString()

* format

Co-authored-by: alafanechere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants