Reduce error boundaries for connections, sources, destinations and onboarding, add retry button. #12848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
edmundito
force-pushed
the
edmundito/reduce-error-boundary
branch
from
0c1607f to
2bef0cc
Compare
I wonder about a few spots in the code where we change "steps" but it isn't reflected in the route (ie: Connection workflow and Onboarding workflow). Would that cause any buggy/unexpected behavior with this? I don't think it would and seems like either way it's an improvement over previous behavior. I'm just curious. |
… when navigating to another page
* Update ApiErrorBoundary to include ability to reset enabled by optional prop withRetry
edmundito
force-pushed
the
edmundito/reduce-error-boundary
branch
from
2bef0cc to
d637b83
Compare
timroes
approved these changes
May 24, 2022
jscottpolevault
pushed a commit
to jscottpolevault/airbyte
that referenced
this pull request
Jun 1, 2022
…boarding, add retry button. (airbytehq#12848) * Add retry logic to ApiErrorBoundary component and move boundary one level deeper * Simplify cannot reach message error message on cloud. * Update ApiErrorBoundary to use Button component, add strings to en.json * Add clearOnLocationChange flag to ApiErrorBoundary to clear the error when navigating to another page * Add error boundaries to DestinationItemPage and SourceItemPage * Update ApiErrorBoundary to include ability to reset enabled by optional prop withRetry * Remove location and retry options from ApiErrorBoundary * Add ApiErrorBoundary to onboarding page * Show titles on most onboarding steps even in error * Add the ability to hide the header for ApiErrorBoundaries and BaseClearView * Remove retry logic from state change in ApiErrorBoundary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This improves how we handle errors in the app. Previously, any network error would cause the app to go into a blank screen with an error. Now the navigation bar will remain present. Additionally, it enables the user to retry the request.
Related to #12172
Onboarding error:
Source/Connection/Destination list error:
Source/destination settings error:
How
ApiErrorBoundarycomponent with retry functionality react-query useQueryResetErrorBoundary. Resets on location change.ApiErrorBoundaryto the main routes so that it doesn't error outside of the navigationApiErrorBoundarycomponent to onboarding, source, destination, and connection components so that it doesn't error the entire pageRecommended reading order
Top to bottom