Skip to content

Improve check connection performance for all JDBC-related DBs #12820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 24, 2022
Merged

Improve check connection performance for all JDBC-related DBs #12820

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
98aeda7
removed redundant read permission check for destination
alexandr-shegeda May 12, 2022
dff32c6
bump docker image versions, update definitions and changelog
alexandr-shegeda May 17, 2022
5871627
Merge branch 'master' into osheg/10376-improved-jdbc-check-perf
alexandr-shegeda May 17, 2022
95518cc
bump docker image versions, update definitions and changelog
alexandr-shegeda May 17, 2022
dbfe2ad
update changelog
alexandr-shegeda May 17, 2022
32500d7
Merge branch 'master' into osheg/10376-improved-jdbc-check-perf
alexandr-shegeda May 18, 2022
4173f83
fix for MSSQL and Oracle tests
alexandr-shegeda May 18, 2022
d3328d6
fix for MSSQL strict encrypt
alexandr-shegeda May 19, 2022
e275428
Merge branch 'master' into osheg/10376-improved-jdbc-check-perf
alexandr-shegeda May 23, 2022
b904854
fixed conflicts
alexandr-shegeda May 23, 2022
591728f
revert versions that were not published
alexandr-shegeda May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...-jdbc/src/main/java/io/airbyte/integrations/destination/jdbc/AbstractJdbcDestination.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ public static void attemptSQLCreateAndDropTableOperations(final String outputSch
final NamingConventionTransformer namingResolver,
final SqlOperations sqlOps)
throws Exception {
// attempt to get metadata from the database as a cheap way of seeing if we can connect.
database.bufferedResultSetQuery(conn -> conn.getMetaData().getCatalogs(), JdbcUtils.getDefaultSourceOperations()::rowToJson);

// verify we have write permissions on the target schema by creating a table with a random name,
// then dropping that table
final String outputTableName = namingResolver.getIdentifier("_airbyte_connection_test_" + UUID.randomUUID().toString().replaceAll("-", ""));
Expand Down