Skip to content

🐛 Source(Pipedrive): remove date-time format from schemas #12806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

joelluijmes
Copy link
Contributor

What

Pipedrive doesn't work with ISO format of date times. Example of format by Pipedrive: 2020-04-15 12:58:48

Now for each record (and inproper datetime formatted value) the worker logs something along as

Errors: $.rotten_time: does not match the time pattern ^\d{2}:\d{2}:\d{2}$, $.last_outgoing_mail_time: 2020-04-15 12:58:48 is an invalid date-time, $.update_time: 2022-05-10 07:40:58 is an invalid date-time, $.stage_change_time: 2022-05-05 23:22:05 is an invalid date-time, $.add_time: 2019-01-04 18:45:25 is an invalid date-time

How

Removed the date-time format

Pipedrive doesn't work with ISO format of date times. Example of format by Pipedrive: 2020-04-15 12:58:48
@github-actions github-actions bot added the area/connectors Connector related issues label May 12, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label May 12, 2022
@harshithmullapudi
Copy link
Contributor

Hey @joelluijmes thanks for the contribution can you share the screenshot of sourceAcceptanceTests.

@harshithmullapudi harshithmullapudi self-requested a review May 17, 2022 07:10
@harshithmullapudi harshithmullapudi self-assigned this May 17, 2022
@harshithmullapudi
Copy link
Contributor

harshithmullapudi commented May 17, 2022

/test connector=source-pipedrive

🕑 source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2337287314
✅ source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/2337287314
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        75      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_incremental.py        85     25    71%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  913    246    73%

@harshithmullapudi
Copy link
Contributor

hey closing this in favor of #13082

@joelluijmes
Copy link
Contributor Author

hey closing this in favor of #13082

Ah my bad. I moved the project from my personal to the companies' github organization. But that must have revoked the push access.

Thanks for the follow up PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants