octavia-cli: enable transformations #12727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
alafanechere
force-pushed
the
augustin/octavia-cli/enable-transformations
branch
from
ae5cd24 to
f99b67e
Compare
lmossman
approved these changes
Jun 3, 2022
Comment on lines
659
to
666
| if "operations" in comparable: | ||
| for operation in comparable["operations"]: | ||
| for k in self.remote_operation_level_keys_to_filter_out: | ||
| operation.pop(k) | ||
| if "dbt" in operation["operator_configuration"] and operation["operator_configuration"]["dbt"] is None: | ||
| operation["operator_configuration"].pop("dbt") | ||
| if "normalization" in operation["operator_configuration"] and operation["operator_configuration"]["normalization"] is None: | ||
| operation["operator_configuration"].pop("normalization") |
There was a problem hiding this comment.
@alafanechere I just wanted to double check: now that we have made the API change to exclude null values, is this logic still necessary?
github-actions
bot
removed
area/api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We want to allow users to set up normalization / custom transformation on their connection managed with
octavia-cli.How
octavia generate:octavia-cli/octavia_cli/generate/commands.py Create a--normalizationoption to enable normalization on generated connection configurations.octavia apply(changes inoctavia-cli/octavia_cli/apply/resources.py):operationson a connection is simpler using theWebBackendConnection*endpoints and models. I changed theresources.pycode make use of these endpoints in model for connection management. This required setting some nullable fields on these models inairbyte-api/src/main/openapi/config.yamlConnection._deserialize_operationsmethod.I also updated unit and integrations tests to test this new feature extensively.