Update the sourceCatalogId field when the schema is updated #12505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- value is not set correctly during update operation - value is not read
github-actions
bot
added
area/api
edmundito
approved these changes
May 3, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* Set SourceCatalogId during connectionUpdate operation * Return catalogId when get a connection * Fix db operation of standardSync.sourceCatalogId - value is not set correctly during update operation - value is not read * UI modification to set the sourceCatalogId * remove sourceCatalogId from diff computation Co-authored-by: alafanechere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user press the refresh schema button, and the save any changes they make to a connection configuration, we make sure we also update the identifier of the catalog that was used during the configuration update