-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Source Facebook Marketing: Add lookback window to insights streams #12402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
d277560
03d5a72
84efdab
c6d00d7
50a3a9d
d30b66d
e12deff
71f326a
b1481da
14b3007
439d527
a0d13f8
384682b
d549143
c86417f
3f67e25
fb66ecb
246c2dd
b39262a
a6577ed
4524fc4
fb99be7
fe1b30a
b7d7973
944783d
7483176
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -77,6 +77,14 @@ class Config: | |||
pattern=DATE_TIME_PATTERN, | ||||
examples=["2017-01-26T00:00:00Z"], | ||||
) | ||||
insights_lookback_window: Optional[PositiveInt] = Field( | ||||
title="Custom Insights Lookback Window", | ||||
description=( | ||||
"The attribution window" | ||||
), | ||||
exclusiveMaximum=28, | ||||
default=28, | ||||
vladimir-remar marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
) | ||||
|
||||
|
||||
class ConnectorConfig(BaseConfig): | ||||
|
@@ -156,3 +164,13 @@ class Config: | |||
"Page size used when sending requests to Facebook API to specify number of records per page when response has pagination. Most users do not need to set this field unless they specifically need to tune the connector to address specific issues or use cases." | ||||
), | ||||
) | ||||
|
||||
insights_lookback_window: Optional[PositiveInt] = Field( | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should make this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for your patience I will work on this ASAP. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey @vladimir-remar I'm not sure you ended up implementing @sherifnada suggestion. Is anything blocking you from going in the suggested direction? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hello @alafanechere, maybe I'm wrong, I just replicate the same approach in the custom insight part. airbyte/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/spec.py Line 80 in c6d00d7
|
||||
title="Insights Lookback Window", | ||||
order=7, | ||||
description=( | ||||
"The attribution window" | ||||
), | ||||
exclusiveMaximum=28, | ||||
default=28, | ||||
) |
Uh oh!
There was an error while loading. Please reload this page.