Skip to content

Generated API Client #12071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 112 commits into from
May 23, 2022
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
112 commits
Select commit Hold shift + click to select a range
23cd0ad
Build added to gradle
krishnaglick Apr 7, 2022
100c86c
Generated the api client
krishnaglick Apr 7, 2022
b3a8090
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 11, 2022
cb11d18
Removing probably
krishnaglick Apr 11, 2022
8e6299f
Import sorting
krishnaglick Apr 12, 2022
a27dae0
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 13, 2022
31086a0
Looks to be working, ready for demoing
krishnaglick Apr 14, 2022
9b6ba75
testing and cleanup
krishnaglick Apr 14, 2022
b60975c
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 14, 2022
ac84164
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 15, 2022
c04bf51
Don't need a script
krishnaglick Apr 15, 2022
5389036
Success.
krishnaglick Apr 15, 2022
cc63359
Remove extra line
krishnaglick Apr 15, 2022
a0ab10e
Going with this
krishnaglick Apr 19, 2022
6684652
App builds
krishnaglick Apr 20, 2022
4b3ff7a
More services converted
krishnaglick Apr 20, 2022
b5a2da9
source auth service converted
krishnaglick Apr 20, 2022
9dea7e0
source definition service done
krishnaglick Apr 20, 2022
4d77a26
Deployment service converted
krishnaglick Apr 20, 2022
02d24d3
Missed a line
krishnaglick Apr 20, 2022
2e3dee1
Hopefully Jobs aren't broken, but needs testing
krishnaglick Apr 20, 2022
45028e5
notification and logs service
krishnaglick Apr 20, 2022
ecd43c1
workspace service swapped
krishnaglick Apr 20, 2022
6b7fb57
health service done
krishnaglick Apr 20, 2022
5bad3e7
workspace service cloud
krishnaglick Apr 20, 2022
97f8b91
rename stripe service typo
krishnaglick Apr 20, 2022
6430b17
First pass done
krishnaglick Apr 20, 2022
1b4738e
Contexts make things difficult at times
krishnaglick Apr 21, 2022
d7c3930
`options` is optional always as far as I can tell
krishnaglick Apr 21, 2022
cff240b
minor cleanup
krishnaglick Apr 21, 2022
3b30e28
Fixed TODO
krishnaglick Apr 21, 2022
4ddc606
Unnecessary async
krishnaglick Apr 21, 2022
82db960
This is marginally better.
krishnaglick Apr 21, 2022
563a8f6
Cleanup
krishnaglick Apr 21, 2022
86716b2
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 21, 2022
f21e082
Minor optional missing
krishnaglick Apr 21, 2022
9acba19
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 22, 2022
f0776e9
Updated from master
krishnaglick Apr 22, 2022
2d02c33
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 22, 2022
1c8b11f
Fix build
krishnaglick Apr 22, 2022
042a622
Better ts
krishnaglick Apr 22, 2022
b20cb55
disabling `any` eslint rule for generated file
krishnaglick Apr 22, 2022
4a7a314
Converted to a hook attempting to fix a weird bug from export *
krishnaglick Apr 22, 2022
bc508bf
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 25, 2022
7cd1cef
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 25, 2022
027866b
Tim Code Review
krishnaglick Apr 25, 2022
dc727f3
Type improvements
krishnaglick Apr 25, 2022
b132e38
Import sorting error
krishnaglick Apr 25, 2022
d084cc5
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 26, 2022
52d820f
Remove unused service
krishnaglick Apr 26, 2022
6d28552
Tim minor code review
krishnaglick Apr 26, 2022
83f88b1
Use generated API over old method
krishnaglick Apr 26, 2022
d40c155
Do not lint generated api
krishnaglick Apr 26, 2022
9e02adf
Move replace for future-proofing
krishnaglick Apr 26, 2022
99ca8c6
More steps towards removing v1 from the api url.
krishnaglick Apr 26, 2022
57449b9
Not needed
krishnaglick Apr 26, 2022
266e24a
Cleaned up
krishnaglick Apr 26, 2022
c1aa976
Remove comment
krishnaglick Apr 26, 2022
f536f61
Matching master
krishnaglick Apr 26, 2022
edec9f4
log download works
krishnaglick Apr 26, 2022
bd22b35
Hard-typing request options
krishnaglick Apr 27, 2022
405aa05
Fixing import
krishnaglick Apr 27, 2022
2b19b36
GeneratedApi -> AirbyteClient
krishnaglick Apr 27, 2022
642e107
Removing weird non-comments
krishnaglick Apr 27, 2022
fff4f92
Linting didn't hit on a few pages
krishnaglick Apr 27, 2022
44e86fd
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 28, 2022
e2e18fe
regenerated generated client
krishnaglick Apr 29, 2022
3e60c82
Better comment
krishnaglick Apr 29, 2022
4e43058
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick Apr 29, 2022
e4cff09
Builds
krishnaglick Apr 29, 2022
9736681
Log types corrected
krishnaglick May 2, 2022
95e5142
Logs more fixed
krishnaglick May 2, 2022
615c7be
Bugfixes
krishnaglick May 2, 2022
46e42dd
minor cleanup
krishnaglick May 2, 2022
4ede983
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick May 2, 2022
0de3ef8
generated client
krishnaglick May 2, 2022
a583972
Fixing some e2e errors
krishnaglick May 4, 2022
63ad0a5
Merge branch 'master' into kc/generated-api-client
krishnaglick May 4, 2022
874b7c1
Fixing build bugs
krishnaglick May 4, 2022
ae8c90e
test to see if this makes CI e2e pass
krishnaglick May 5, 2022
771042b
Merge branch 'master' into kc/generated-api-client
krishnaglick May 6, 2022
d7317c4
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick May 6, 2022
87d7f6b
Edmundo code review
krishnaglick May 6, 2022
ab55a0c
More CR
krishnaglick May 6, 2022
47c2b86
better types
krishnaglick May 9, 2022
a46b7c1
Fixed normalization I think
krishnaglick May 9, 2022
c01b497
cleanup
krishnaglick May 9, 2022
c793c2b
Cleaning up types
krishnaglick May 9, 2022
d7018a0
Remove old type
krishnaglick May 9, 2022
a6312d4
Merge remote-tracking branch 'origin' into kc/generated-api-client
krishnaglick May 9, 2022
75a4704
Remove more unused types
krishnaglick May 9, 2022
99d4001
More type cleanup
krishnaglick May 9, 2022
1dd176d
Regenerated client & fixed build
krishnaglick May 9, 2022
2923563
Improvements, and one bugfix
krishnaglick May 9, 2022
f0854c1
Better normalization selection logic
krishnaglick May 10, 2022
21f0a48
Merge remote-tracking branch 'origin' into kc/generated-api-client
krishnaglick May 10, 2022
d973657
Merge branch 'master' into kc/generated-api-client
May 13, 2022
e0225e5
Remove errant console.log ty Teal
krishnaglick May 13, 2022
bd8686c
Fixing broken normalization
krishnaglick May 13, 2022
a9c8dbc
Fix issue with v1 in cloud envs
May 16, 2022
3ac4fe7
Merge branch 'master' into kc/generated-api-client
May 16, 2022
91e69d8
Adjust master merge error
May 16, 2022
d3748f5
Automatically prettify generated code
May 16, 2022
befd4cd
Remove duplicate slash from URLs
May 16, 2022
9e95a35
Update airbyte-webapp/src/components/JobItem/JobItem.tsx
May 17, 2022
88fce9d
Update airbyte-webapp/src/components/JobItem/JobItem.tsx
May 17, 2022
861d496
Merge branch 'master' into kc/generated-api-client
May 19, 2022
9df43b3
Fix attempt summary
May 19, 2022
c6502bc
Merge branch 'master' into kc/generated-api-client
May 20, 2022
5bd5eb9
Fix showing correct log
May 20, 2022
e42971f
Merge branch 'master' into kc/generated-api-client
timroes May 23, 2022
74c8437
Regenerate API client
timroes May 23, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-webapp/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ task copyNginx(type: Copy) {
into "build/docker/bin/nginx"
}


copyBuild.dependsOn npm_run_build
copyNginx.dependsOn npm_run_build
copyDocs.dependsOn npm_run_build
Expand Down
21 changes: 21 additions & 0 deletions airbyte-webapp/orval.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { defineConfig } from "orval";

export default defineConfig({
api: {
input: "../airbyte-api/src/main/openapi/config.yaml",
output: {
target: "./src/core/request/GeneratedApi.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @tealjulia's suggestion, how about ./src/core/airbyteClient.ts ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Unfortunately that caused almost every file to count as touched.

override: {
operationName: (operation) =>
`use${operation.operationId
.split("")
.map((v, i) => (i === 0 ? v.toUpperCase() : v))
.join("")}`,
mutator: {
path: "./src/core/request/useApiOverride.ts",
name: "useApiOverride",
},
},
},
},
});
Loading