-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Generated API Client #12071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Generated API Client #12071
Changes from 12 commits
Commits
Show all changes
112 commits
Select commit
Hold shift + click to select a range
23cd0ad
Build added to gradle
krishnaglick 100c86c
Generated the api client
krishnaglick b3a8090
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick cb11d18
Removing probably
krishnaglick 8e6299f
Import sorting
krishnaglick a27dae0
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick 31086a0
Looks to be working, ready for demoing
krishnaglick 9b6ba75
testing and cleanup
krishnaglick b60975c
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick ac84164
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick c04bf51
Don't need a script
krishnaglick 5389036
Success.
krishnaglick cc63359
Remove extra line
krishnaglick a0ab10e
Going with this
krishnaglick 6684652
App builds
krishnaglick 4b3ff7a
More services converted
krishnaglick b5a2da9
source auth service converted
krishnaglick 9dea7e0
source definition service done
krishnaglick 4d77a26
Deployment service converted
krishnaglick 02d24d3
Missed a line
krishnaglick 2e3dee1
Hopefully Jobs aren't broken, but needs testing
krishnaglick 45028e5
notification and logs service
krishnaglick ecd43c1
workspace service swapped
krishnaglick 6b7fb57
health service done
krishnaglick 5bad3e7
workspace service cloud
krishnaglick 97f8b91
rename stripe service typo
krishnaglick 6430b17
First pass done
krishnaglick 1b4738e
Contexts make things difficult at times
krishnaglick d7c3930
`options` is optional always as far as I can tell
krishnaglick cff240b
minor cleanup
krishnaglick 3b30e28
Fixed TODO
krishnaglick 4ddc606
Unnecessary async
krishnaglick 82db960
This is marginally better.
krishnaglick 563a8f6
Cleanup
krishnaglick 86716b2
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick f21e082
Minor optional missing
krishnaglick 9acba19
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick f0776e9
Updated from master
krishnaglick 2d02c33
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick 1c8b11f
Fix build
krishnaglick 042a622
Better ts
krishnaglick b20cb55
disabling `any` eslint rule for generated file
krishnaglick 4a7a314
Converted to a hook attempting to fix a weird bug from export *
krishnaglick bc508bf
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick 7cd1cef
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick 027866b
Tim Code Review
krishnaglick dc727f3
Type improvements
krishnaglick b132e38
Import sorting error
krishnaglick d084cc5
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick 52d820f
Remove unused service
krishnaglick 6d28552
Tim minor code review
krishnaglick 83f88b1
Use generated API over old method
krishnaglick d40c155
Do not lint generated api
krishnaglick 9e02adf
Move replace for future-proofing
krishnaglick 99ca8c6
More steps towards removing v1 from the api url.
krishnaglick 57449b9
Not needed
krishnaglick 266e24a
Cleaned up
krishnaglick c1aa976
Remove comment
krishnaglick f536f61
Matching master
krishnaglick edec9f4
log download works
krishnaglick bd22b35
Hard-typing request options
krishnaglick 405aa05
Fixing import
krishnaglick 2b19b36
GeneratedApi -> AirbyteClient
krishnaglick 642e107
Removing weird non-comments
krishnaglick fff4f92
Linting didn't hit on a few pages
krishnaglick 44e86fd
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick e2e18fe
regenerated generated client
krishnaglick 3e60c82
Better comment
krishnaglick 4e43058
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick e4cff09
Builds
krishnaglick 9736681
Log types corrected
krishnaglick 95e5142
Logs more fixed
krishnaglick 615c7be
Bugfixes
krishnaglick 46e42dd
minor cleanup
krishnaglick 4ede983
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick 0de3ef8
generated client
krishnaglick a583972
Fixing some e2e errors
krishnaglick 63ad0a5
Merge branch 'master' into kc/generated-api-client
krishnaglick 874b7c1
Fixing build bugs
krishnaglick ae8c90e
test to see if this makes CI e2e pass
krishnaglick 771042b
Merge branch 'master' into kc/generated-api-client
krishnaglick d7317c4
Merge branch 'master' of github.com:airbytehq/airbyte into kc/generat…
krishnaglick 87d7f6b
Edmundo code review
krishnaglick ab55a0c
More CR
krishnaglick 47c2b86
better types
krishnaglick a46b7c1
Fixed normalization I think
krishnaglick c01b497
cleanup
krishnaglick c793c2b
Cleaning up types
krishnaglick d7018a0
Remove old type
krishnaglick a6312d4
Merge remote-tracking branch 'origin' into kc/generated-api-client
krishnaglick 75a4704
Remove more unused types
krishnaglick 99d4001
More type cleanup
krishnaglick 1dd176d
Regenerated client & fixed build
krishnaglick 2923563
Improvements, and one bugfix
krishnaglick f0854c1
Better normalization selection logic
krishnaglick 21f0a48
Merge remote-tracking branch 'origin' into kc/generated-api-client
krishnaglick d973657
Merge branch 'master' into kc/generated-api-client
e0225e5
Remove errant console.log ty Teal
krishnaglick bd8686c
Fixing broken normalization
krishnaglick a9c8dbc
Fix issue with v1 in cloud envs
3ac4fe7
Merge branch 'master' into kc/generated-api-client
91e69d8
Adjust master merge error
d3748f5
Automatically prettify generated code
befd4cd
Remove duplicate slash from URLs
9e95a35
Update airbyte-webapp/src/components/JobItem/JobItem.tsx
88fce9d
Update airbyte-webapp/src/components/JobItem/JobItem.tsx
861d496
Merge branch 'master' into kc/generated-api-client
9df43b3
Fix attempt summary
c6502bc
Merge branch 'master' into kc/generated-api-client
5bd5eb9
Fix showing correct log
e42971f
Merge branch 'master' into kc/generated-api-client
timroes 74c8437
Regenerate API client
timroes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { defineConfig } from "orval"; | ||
|
||
export default defineConfig({ | ||
api: { | ||
input: "../airbyte-api/src/main/openapi/config.yaml", | ||
output: { | ||
target: "./src/core/request/GeneratedApi.ts", | ||
override: { | ||
operationName: (operation) => | ||
`use${operation.operationId | ||
.split("") | ||
.map((v, i) => (i === 0 ? v.toUpperCase() : v)) | ||
.join("")}`, | ||
mutator: { | ||
path: "./src/core/request/useApiOverride.ts", | ||
name: "useApiOverride", | ||
}, | ||
}, | ||
}, | ||
}, | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on @tealjulia's suggestion, how about
./src/core/airbyteClient.ts
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Unfortunately that caused almost every file to count as touched.