Skip to content

Fix pre-commit hook failing because of black #11737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Fix pre-commit hook failing because of black #11737

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a70015
update black version
Phlair Apr 5, 2022
e38486d
Update .pre-commit-config.yaml
Phlair Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ repos:
hooks:
- id: licenseheaders
args: ["--tmpl=LICENSE_SHORT", "--ext=py", "-f"]
- repo: https://github.com/ambv/black
rev: 22.1.0
- repo: https://github.com/psf/black
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no context and am just curious: why did we switch maintainers? A quick look at both GitHub pages didn't give me a clear answer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ambv/black is now redirecting to https://github.com/psf/black so it's not an actual maintainer switch, arguably unnecessary but just for clarity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Cool cool cool. thanks for the context

rev: 22.3.0
hooks:
- id: black
args: ["--config", "pyproject.toml"]
Expand Down