Skip to content

Improve onboarding performance #11682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2022
Merged

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Apr 3, 2022

What

Fixes #10403

This adds a new web_backend API to determine the onboarding state of a workspace, i.e. return whether it has sources/destinations/connections via one API, so we don't require to call all list APIs separately just to figure out the count.

Also move logic from the OnboardingPage into the individual steps, so that we don't need to load the data required in ANY step upfront before rendering the first step.

This significantly improves page loading of the onboarding step for a new user. There'll now be a (smaller) page load size on each step, for loading the corresponding data needed (e.g. the source definitions in the source step, which were earlier all loaded upfront).

@timroes timroes temporarily deployed to more-secrets April 3, 2022 05:52 Inactive
@timroes timroes temporarily deployed to more-secrets April 3, 2022 05:52 Inactive
@github-actions github-actions bot added area/api Related to the api area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/server labels Apr 3, 2022
@timroes timroes temporarily deployed to more-secrets April 3, 2022 14:25 Inactive
@timroes timroes temporarily deployed to more-secrets April 3, 2022 14:25 Inactive
@timroes timroes temporarily deployed to more-secrets April 3, 2022 14:45 Inactive
@timroes timroes temporarily deployed to more-secrets April 3, 2022 14:46 Inactive
@timroes timroes marked this pull request as ready for review April 3, 2022 16:45
@timroes timroes requested a review from a team as a code owner April 3, 2022 16:45
@timroes timroes requested a review from malikdiarra April 3, 2022 16:45
@timroes timroes temporarily deployed to more-secrets April 5, 2022 00:09 Inactive
@timroes timroes temporarily deployed to more-secrets April 5, 2022 00:09 Inactive
@timroes timroes temporarily deployed to more-secrets April 5, 2022 00:31 Inactive
@timroes timroes temporarily deployed to more-secrets April 5, 2022 00:32 Inactive
@timroes timroes temporarily deployed to more-secrets April 5, 2022 00:43 Inactive
@timroes timroes temporarily deployed to more-secrets April 5, 2022 00:43 Inactive
@timroes timroes merged commit 25b65c6 into master Apr 5, 2022
@timroes timroes deleted the tim/improve-onboarding-performance branch April 5, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load onboarding state via backend API
2 participants