Skip to content

Source Zendesk Support: Delete unused field and update links to dec #11671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Apr 2, 2022

What

@github-actions github-actions bot added the area/connectors Connector related issues label Apr 2, 2022
@girarda
Copy link
Contributor Author

girarda commented Apr 2, 2022

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2080400277
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/2080400277
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_zendesk_support/__init__.py       2      0   100%
source_zendesk_support/streams.py      290     57    80%
source_zendesk_support/source.py        45     25    44%
--------------------------------------------------------
TOTAL                                  337     82    76%

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@e9946c9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11671   +/-   ##
=========================================
  Coverage          ?   75.66%           
=========================================
  Files             ?        3           
  Lines             ?      337           
  Branches          ?        0           
=========================================
  Hits              ?      255           
  Misses            ?       82           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9946c9...c48f1a2. Read the comment docs.

@girarda girarda requested a review from sherifnada April 2, 2022 00:38
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but make sure to add a comment in the PR description for posterity

@girarda girarda changed the title Clean up zendesk streams Source Zendesk Support: Delete unused field and update links to dec Apr 2, 2022
@girarda girarda merged commit 73b88de into master Apr 2, 2022
@girarda girarda deleted the alex/testzendesk branch April 2, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants