Skip to content

Skip empty line output from gradle #11667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Skip empty line output from gradle #11667

merged 1 commit into from
Apr 4, 2022

Conversation

grishick
Copy link
Contributor

@grishick grishick commented Apr 1, 2022

Currently, every time this script attempts to launch a github action for an empty connector name
see log output here: https://github.com/airbytehq/airbyte/runs/5786705935?check_suite_focus=true
This change fixes this minor bug.

  Currently, every time this script attempts to launch a github action for an empty connector name
  see log output here: https://github.com/airbytehq/airbyte/runs/5786705935?check_suite_focus=true
  This change fixes this minor bug.
@grishick grishick requested a review from sherifnada April 1, 2022 19:31
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grishick grishick temporarily deployed to more-secrets April 1, 2022 19:32 Inactive
@grishick grishick temporarily deployed to more-secrets April 1, 2022 19:32 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be helpful for debugging to log that it's empty in an else clause

@grishick
Copy link
Contributor Author

grishick commented Apr 1, 2022

Would be helpful for debugging to log that it's empty in an else clause

Hm.. what for? It's just an artifact of how gradle output is parsed. The empty line is always there.

@sherifnada
Copy link
Contributor

@grishick oh ok i see, no need then

@grishick grishick merged commit afc1976 into master Apr 4, 2022
@grishick grishick deleted the greg/skip-empty-lines branch April 4, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants