Skip to content

Python CDK - Fix BaseBackoffException constructor #11653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Apr 1, 2022

Signed-off-by: Sergey Chvalyuk [email protected]

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the CDK Connector Development Kit label Apr 1, 2022
@grubberr grubberr changed the title - Fix BaseBackoffException constructor Python CDK - Fix BaseBackoffException constructor Apr 1, 2022
@grubberr grubberr mentioned this pull request Apr 1, 2022
40 tasks
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@4b9a077). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11653   +/-   ##
=========================================
  Coverage          ?   88.39%           
=========================================
  Files             ?       37           
  Lines             ?     1637           
  Branches          ?        0           
=========================================
  Hits              ?     1447           
  Misses            ?      190           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9a077...9f5f400. Read the comment docs.

@grubberr grubberr requested a review from lazebnyi April 1, 2022 09:15
@bazarnov
Copy link
Collaborator

bazarnov commented Apr 1, 2022

@grubberr
Let's run the test publish using /publish-cdk dry-run=true

@grubberr
Copy link
Contributor Author

grubberr commented Apr 1, 2022

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/2076526582
https://github.com/airbytehq/airbyte/actions/runs/2076526582

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @grubberr

@grubberr
Copy link
Contributor Author

grubberr commented Apr 1, 2022

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/2078271927
https://github.com/airbytehq/airbyte/actions/runs/2078271927

@grubberr
Copy link
Contributor Author

grubberr commented Apr 1, 2022

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/2078316314
https://github.com/airbytehq/airbyte/actions/runs/2078316314

@grubberr grubberr merged commit df12c9e into master Apr 1, 2022
@grubberr grubberr deleted the grubberr/airbyte-cdk_fix_basebackoffexception branch April 1, 2022 16:05
@lazebnyi lazebnyi removed their request for review May 30, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants