Skip to content

Add one more error boundary layer for not found #11626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2022
Merged

Add one more error boundary layer for not found #11626

merged 2 commits into from
Apr 1, 2022

Conversation

jamakase
Copy link
Contributor

Fix regression when common error view was displayed for not found resource instead of proper one.

image

@jamakase jamakase requested a review from a team as a code owner March 31, 2022 12:40
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Mar 31, 2022
@jamakase jamakase self-assigned this Mar 31, 2022
timroes
timroes approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jamakase jamakase merged commit 4b9a077 into master Apr 1, 2022
@jamakase jamakase deleted the jamakase/add-workspace-not-found-handling branch April 1, 2022 14:51
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees

@jamakase jamakase

Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamakase @timroes