🎉 Source Google Ads: campaign stream includes campaign_budget.amount_micros #11602

edgao · 2022-03-30T20:19:18Z

What

Previously we only fetched campaign.campaign_budget, which is the resource ID of the budget. We now fetch the actual value of the budget as a new field.

Tested this on a local airbyte instance (GAds -> local JSON) and verified that it fetches the field correctly.

🚨 User Impact 🚨

none

Pre-merge Checklist

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

edgao · 2022-03-30T20:19:43Z

/test connector=connectors/source-google-ads

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >600.0s
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 20 passed, 1 skipped in 1658.90s (0:27:38) =============

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >600.0s
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 20 passed, 1 skipped in 1767.35s (0:29:27) =============

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 20 passed, 1 skipped in 1426.02s (0:23:46) =============

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 2 failed, 19 passed, 1 skipped in 775.91s (0:12:55) ==============

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 20 passed, 1 skipped in 1523.49s (0:25:23) =============

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >600.0s
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 20 passed, 1 skipped in 1807.42s (0:30:07) =============

girarda · 2022-03-30T21:01:38Z

@edgao looks like the test failed. do you know if it times out on master too? If so, should we increase the timeout?

edgao · 2022-03-30T21:25:23Z

welp. this happens transiently, never actually tracked it down to a root cause. retrying and hoping it works a second time :/

girarda

Approved pending a successful test execution

edgao · 2022-04-04T18:42:38Z

/test connector=connectors/source-google-ads

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 2 failed, 19 passed, 1 skipped in 1406.11s (0:23:26) =============

edgao · 2022-04-04T19:40:18Z

/test connector=connectors/source-google-ads

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               68     10    85%
source_google_ads/streams.py                 136     25    82%
source_google_ads/source.py                   80     27    66%
source_google_ads/custom_query_stream.py      75     50    33%
--------------------------------------------------------------
TOTAL                                        361    112    69%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/source.py                   80      4    95%
source_google_ads/streams.py                 136     10    93%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               68      7    90%
--------------------------------------------------------------
TOTAL                                        361     27    93%

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 1779.15s (0:29:39) ==================

edgao · 2022-04-04T20:25:13Z

/publish connector=connectors/source-google-ads

fetch budget amount micros

71f4e74

github-actions bot added the area/connectors Connector related issues label Mar 30, 2022

edgao marked this pull request as ready for review March 30, 2022 20:21

edgao requested a review from girarda March 30, 2022 20:21

girarda approved these changes Mar 30, 2022

View reviewed changes

edgao added 2 commits April 4, 2022 12:39

correct type?

5f7761b

Merge branch 'master' into edgao/source_gads_budget

2aedd66

bump version

ae5bda5

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 4, 2022

regenerate

d6bfe07

edgao temporarily deployed to more-secrets April 4, 2022 21:18 Inactive

edgao merged commit fede479 into master Apr 4, 2022

edgao deleted the edgao/source_gads_budget branch April 4, 2022 22:17

octavia-squidington-iii mentioned this pull request Apr 5, 2022

Bump Airbyte version from 0.35.64-alpha to 0.35.65-alpha #11722

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Google Ads: campaign stream includes campaign_budget.amount_micros #11602

🎉 Source Google Ads: campaign stream includes campaign_budget.amount_micros #11602

edgao commented Mar 30, 2022 •

edited

Loading

edgao commented Mar 30, 2022 •

edited by github-actions bot

Loading

girarda commented Mar 30, 2022

edgao commented Mar 30, 2022

girarda left a comment

edgao commented Apr 4, 2022 •

edited by github-actions bot

Loading

edgao commented Apr 4, 2022 •

edited by github-actions bot

Loading

edgao commented Apr 4, 2022 •

edited by github-actions bot

Loading

🎉 Source Google Ads: campaign stream includes campaign_budget.amount_micros #11602

🎉 Source Google Ads: campaign stream includes campaign_budget.amount_micros #11602

Conversation

edgao commented Mar 30, 2022 • edited Loading

What

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

edgao commented Mar 30, 2022 • edited by github-actions bot Loading

girarda commented Mar 30, 2022

edgao commented Mar 30, 2022

girarda left a comment

Choose a reason for hiding this comment

edgao commented Apr 4, 2022 • edited by github-actions bot Loading

edgao commented Apr 4, 2022 • edited by github-actions bot Loading

edgao commented Apr 4, 2022 • edited by github-actions bot Loading

edgao commented Mar 30, 2022 •

edited

Loading

edgao commented Mar 30, 2022 •

edited by github-actions bot

Loading

edgao commented Apr 4, 2022 •

edited by github-actions bot

Loading

edgao commented Apr 4, 2022 •

edited by github-actions bot

Loading

edgao commented Apr 4, 2022 •

edited by github-actions bot

Loading