Skip to content

Source Github: get_updated_state problem on reviews stream #11567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 31, 2022
Merged

Source Github: get_updated_state problem on reviews stream #11567

merged 8 commits into from
Mar 31, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Mar 30, 2022 •
edited
Loading

Signed-off-by: Sergey Chvalyuk [email protected]

What

GitHub Source failed for stream reviews:

File "/airbyte/integration_code/source_github/streams.py", line 213, in get_updated_state
    state_value = max(latest_cursor_value, current_stream_state[current_repository][self.cursor_field])
TypeError: '>' not supported between instances of 'str' and 'NoneType'

How

I suspect that record missed cursor_field, but I want to be 100% sure
I have refactored code to better see source of problem

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 30, 2022
@grubberr grubberr temporarily deployed to more-secrets March 30, 2022 08:26 Inactive
@grubberr grubberr temporarily deployed to more-secrets March 30, 2022 08:27 Inactive
@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@152af7c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 23a2269 differs from pull request most recent head 0bf49d6. Consider uploading reports for the commit 0bf49d6 to get more accurate results

@@            Coverage Diff            @@
##             master   #11567   +/-   ##
=========================================
  Coverage          ?   88.42%           
=========================================
  Files             ?        3           
  Lines             ?      570           
  Branches          ?        0           
=========================================
  Hits              ?      504           
  Misses            ?       66           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152af7c...0bf49d6. Read the comment docs.

@grubberr
github.md updated
b81e8a1 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-github

@grubberr grubberr temporarily deployed to more-secrets March 30, 2022 09:02 Inactive
@grubberr grubberr temporarily deployed to more-secrets March 30, 2022 09:02 Inactive
@grubberr grubberr linked an issue Mar 30, 2022 that may be closed by this pull request
Source Github: get_updated_state problem on reviews stream #11566
Closed
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-github

2 similar comments
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-github

@grubberr
Copy link
Contributor Author

/test connector=connectors/source-github

@grubberr grubberr self-assigned this Mar 30, 2022
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-github

@grubberr
Copy link
Contributor Author

/test connector=connectors/source-github

@grubberr grubberr temporarily deployed to more-secrets March 30, 2022 11:53 Inactive
@grubberr grubberr temporarily deployed to more-secrets March 30, 2022 11:53 Inactive
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-github

@grubberr
Copy link
Contributor Author

grubberr commented Mar 30, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2067299209
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2067299209
🐛 https://gradle.com/s/venv2en3m4ntc
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
==================== 6 failed, 22 passed, 1 error in 10.72s ====================

@grubberr grubberr temporarily deployed to more-secrets March 30, 2022 20:43 Inactive
@grubberr grubberr temporarily deployed to more-secrets March 30, 2022 20:43 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Mar 30, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2067373889
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2067373889
🐛 https://gradle.com/s/3orrycitgkibo
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
==================== 6 failed, 22 passed, 1 error in 10.93s ====================

@grubberr
Copy link
Contributor Author

grubberr commented Mar 31, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2068980116
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2068980116
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/streams.py      466     34    93%
source_github/source.py        89     24    73%
-----------------------------------------------
TOTAL                         557     58    90%

@grubberr
Copy link
Contributor Author

grubberr commented Mar 31, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2069020049
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2069020049
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/streams.py      480     42    91%
source_github/source.py        89     24    73%
-----------------------------------------------
TOTAL                         571     66    88%

@grubberr
bump version 0.2.24 -> 0.2.25
b99d887 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets March 31, 2022 05:39 Inactive
@grubberr grubberr temporarily deployed to more-secrets March 31, 2022 05:39 Inactive
@grubberr
github.md updated
23a2269 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets March 31, 2022 05:44 Inactive
@grubberr grubberr temporarily deployed to more-secrets March 31, 2022 05:44 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Mar 31, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2069662537
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2069662537

@grubberr
source_specs.yaml updated
0bf49d6 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr merged commit b75295a into master Mar 31, 2022
@grubberr grubberr deleted the grubberr/11566-source-github-reviews branch March 31, 2022 08:05
@grubberr grubberr temporarily deployed to more-secrets March 31, 2022 08:06 Inactive
@grubberr grubberr temporarily deployed to more-secrets March 31, 2022 08:06 Inactive
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davydov-d davydov-d davydov-d approved these changes

@bazarnov bazarnov bazarnov approved these changes

@midavadim midavadim Awaiting requested review from midavadim

Assignees

@grubberr grubberr

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Github: get_updated_state problem on reviews stream
3 participants
@grubberr @davydov-d @bazarnov