Skip to content

🐛 octavia-cli: use list endpoint instead of list_latest #11505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 30, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Mar 29, 2022

What

I mistakenly used the /v1/*_definitions/list_latest in the octavia list connectors command.
The /v1/*_definitions/list should be used to retrieve the connector version installed on the Airbyte instance, not the latest version.

How

  • Use list_*_definitions function instead of list_latest_*_definitions
  • Update unit tests
  • Write integration tests on the *Listing classes.
  • Change the help messages displayed on the octavia list connectors commands to match the command reference in the README
  • Refactor existing integration test:
    • make fixtures that reference remote resources session-scoped and not module-scoped + declare these fixtures in conftest.py

Recommended reading order

  1. octavia-cli/octavia_cli/list/listings.py
  2. octavia-cli/unit_tests/test_list/test_listings.py
  3. octavia-cli/integration_tests/conftest.py
  4. octavia-cli/octavia_cli/list/commands.py

@alafanechere alafanechere marked this pull request as ready for review March 29, 2022 16:53
@alafanechere alafanechere added this to the octavia-cli-alpha milestone Mar 29, 2022
@ChristopheDuong
Copy link
Contributor

ChristopheDuong commented Mar 30, 2022

Is it possible to also run list_latest from the CLI though?

It might be useful for scripts based on Octavia cli to compare externally if they need to perform some upgrades on connectors and identify which ones are concerned?

@alafanechere
Copy link
Contributor Author

Is it possible to also run list_latest from the CLI though?

It might be useful for scripts based on Octavia cli to compare externally if they need to perform some upgrades on connectors and identify which ones are concerned?

Thanks for the review @ChristopheDuong, I opened an issue to implement list latest in the future: https://github.com/airbytehq/airbyte-internal-issues/issues/532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants