Skip to content

SAT: local python tests log git hash with success or failure #11497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 29, 2022

Conversation

Phlair
Copy link
Contributor

@Phlair Phlair commented Mar 29, 2022

What

Solving #4534

How

Using pytest's sessionfinish hook to log a message after SATs run locally, containing:

  • local folder connector tests were run for
  • the git hash of the code used
  • whether tests passed or failed

Contributor can provide a screenshot of this in their PR as evidence of SAT passing locally.

Examples:

Pass
Screenshot 2022-03-29 at 10 37 45

Fail
Screenshot 2022-03-29 at 10 39 32

@Phlair Phlair requested a review from sherifnada March 29, 2022 10:00
@Phlair Phlair self-assigned this Mar 29, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Mar 29, 2022
@Phlair Phlair added area/connectors Connector related issues area/live-tests labels Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@84b2d32). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11497   +/-   ##
=========================================
  Coverage          ?   70.12%           
=========================================
  Files             ?       13           
  Lines             ?      867           
  Branches          ?        0           
=========================================
  Hits              ?      608           
  Misses            ?      259           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b2d32...be52cb7. Read the comment docs.

@github-actions github-actions bot removed the area/connectors Connector related issues label Mar 29, 2022
@Phlair Phlair changed the title SAT: local python tests now log git hash with success or failure SAT: local python tests log git hash with success or failure Mar 29, 2022
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation area/live-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants