Adds valid PAT testing to existing ec2 pipes #11486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds the same workflow seen in gradle.yml to other pipelines
davinchia
reviewed
Mar 29, 2022
| id: variables | ||
| run: | | ||
| ./tools/bin/find_non_rate_limited_PAT \ | ||
| ${{ secrets.SUPERTOPHER_PAT }} \ |
There was a problem hiding this comment.
we should update this to the token list we spoke about before merging this in.
There was a problem hiding this comment.
same for the rest of the jobs.
davinchia
approved these changes
Mar 29, 2022
rename SELF_RUNNER_GITHUB_ACCESS_TOKEN_1 -> DAVINCHIA_PAT remove LABEL_BOT_USERNAME
supertopher
commented
Mar 29, 2022
| @@ -12,4 +12,4 @@ jobs: | |||
| - uses: harshithmullapudi/label-actions@75686c2b3de17244526f10a22424f319d0bc134f | |||
| with: | |||
| github-token: ${{ secrets.OCTAVIA_PAT }} | |||
| github-username: ${{ secrets.LABEL_BOT_USERNAME }} | |||
| github-username: octavia-squidington-iii | |||
There was a problem hiding this comment.
Whatever we were using before it's Octavia now, I'm killing these secrets after this
This was referenced Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the same workflow seen in gradle.yml to other pipelines
What
grade.yml is running through PAT keys to check for valid keys. lets do that elsewhere
How
adds a need before GitHub token invoking the supertopher branch