Skip to content

🐙 octavia-cli: bump with same version as Airbyte #11464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 29, 2022
Merged

🐙 octavia-cli: bump with same version as Airbyte #11464

merged 13 commits into from
Mar 29, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Mar 28, 2022 •
edited
Loading

What

Airbyte's API is the core dependency of octavia-cli.
As Airbyte API is versioned with the Airbyte platform we should version octavia-cli with the Airbyte platform to guarantee compatibility and avoid regressions.

How

  • Add octavia-cli version files to .bumpversion.cfg
  • Update octavia-cli version to the latest Airbyte version
  • Run the octavia-cli publish script from release_version.sh

@alafanechere alafanechere force-pushed the augustin/octavia-cli/bump-with-airbyte branch from 4e7e0e3 to 59a0d4d Compare March 28, 2022 10:48
@alafanechere alafanechere changed the title 🐙 octavia-cli: bump octavia same version as Airbyte 🐙 octavia-cli: bump with same version as Airbyte Mar 28, 2022
@alafanechere alafanechere force-pushed the augustin/octavia-cli/bump-with-airbyte branch from 95e7113 to 7cd56e9 Compare March 28, 2022 11:00
@alafanechere alafanechere marked this pull request as ready for review March 28, 2022 11:00
@alafanechere alafanechere temporarily deployed to more-secrets March 28, 2022 11:03 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 28, 2022 11:03 Inactive
@alafanechere alafanechere added this to the octavia-cli-alpha milestone Mar 28, 2022
@alafanechere alafanechere temporarily deployed to more-secrets March 28, 2022 17:46 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 28, 2022 17:46 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 28, 2022 18:01 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 28, 2022 18:02 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 28, 2022 18:52 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 28, 2022 18:53 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 28, 2022 20:20 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 29, 2022 08:26 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 29, 2022 08:26 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 29, 2022 11:43 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 29, 2022 11:43 Inactive
davinchia
davinchia reviewed Mar 29, 2022
View reviewed changes
davinchia
davinchia reviewed Mar 29, 2022
View reviewed changes
davinchia
davinchia reviewed Mar 29, 2022
View reviewed changes
davinchia
davinchia approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Good to merge once we resolve the comments.

@alafanechere alafanechere merged commit 9d46ef8 into master Mar 29, 2022
@alafanechere alafanechere deleted the augustin/octavia-cli/bump-with-airbyte branch March 29, 2022 17:22
@alafanechere alafanechere mentioned this pull request Mar 29, 2022
Closed
@alafanechere alafanechere temporarily deployed to more-secrets March 29, 2022 17:23 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 29, 2022 17:23 Inactive
@alafanechere alafanechere mentioned this pull request Mar 29, 2022
Merged
This was referenced Mar 29, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopheDuong ChristopheDuong ChristopheDuong left review comments

@davinchia davinchia davinchia approved these changes

@jrhizor jrhizor Awaiting requested review from jrhizor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
octavia-cli-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@alafanechere @ChristopheDuong @davinchia