-
Notifications
You must be signed in to change notification settings - Fork 4.6k
🎉BigQuery denormalized Destination: Integration test enhancement for picking test-data and schemas #11454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉BigQuery denormalized Destination: Integration test enhancement for picking test-data and schemas #11454
Conversation
…t for picking test-data and schemas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally someone fixed my gap :D
/test connector=connectors/destination-bigquery-denormalized
|
What
Currently, all schemas and data for BigQueryDenormalizedDestinationTest are taken from
BigQueryDenormalizedTestDataUtils as json string which seems to be difficult to support and change.
How
Moved all schemas and data into resources folder and make changes into BigQueryDenormalizedTestDataUtils in order to read json data from resources
🚨 User Impact 🚨
No breaking changes just updated tests
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.