-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🐛 octavia-cli: propagate open api spec update #11441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 octavia-cli: propagate open api spec update #11441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a couple questions about the tests but I don't think they are blocking. The other changes here seem fine to me!
@pytest.fixture(scope="module") | ||
def source_state_path(): | ||
state_path = f"{os.path.dirname(__file__)}/configurations/sources/poke/state.yaml" | ||
silent_remove(state_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why these methods are calling remove
on state_path
? Or why its calling silent_remove()
twice?
And similarly, why are the source()
and destination()
methods calling delete_source()
/delete_destination()
after yielding them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the context of pytest fixtures, the code after yielding is considered as the test teardown logic. I'm basically cleaning up state files and remote resources at the end of the test run.
What
Closes #11438
How
octavia-cli/integration_tests/test_apply/test_resources.py
. The test configuration files explain the number of new lines in this PR 😄SourceIdRequestBody
toSourceDiscoverSchemaRequestBody
.Todo
airbyte-api
folder (and on theoctavia-cli
folder of course).