Skip to content

Fix service form tests #11433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Fix service form tests #11433

merged 3 commits into from
Mar 30, 2022

Conversation

jamakase
Copy link
Contributor

What

  • Fixes ignored tests in ServiceForm
  • Minor updates to ServiceForm.PatchInitialValuesWithWidgetConfig so it is applied on correct values and do not overwrite name changes.

@jamakase jamakase requested a review from a team as a code owner March 25, 2022 13:49
@jamakase jamakase self-assigned this Mar 25, 2022
@github-actions github-actions bot added the area/platform issues related to the platform label Mar 25, 2022
@jamakase jamakase changed the title Jamakase/fix service form tests Fix service form tests Mar 25, 2022
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, existing behavior of setting names when switching connectors works. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants