List private definitions endpoint #11339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
| description: true if this connector definition is available to all workspaces | ||
| type: boolean | ||
| default: false | ||
| custom: |
There was a problem hiding this comment.
What is the definition of custom vs public? I would be careful before adding that kind of specific flags on the data model. They risk proliferating.
Are they mutually exclusive? then it should be a enum and if we foresee that it is only these two states then just one boolean
Can it be true on both? false on both? what is the expected behavior in these cases?
There was a problem hiding this comment.
Great points. Let me copy this over to #11305 (which has these same migration and model changes broken out into its own PR) and continue the discussion there.
Worth discussing since there was a thread about this in the design doc as well
Discussion continued in #11305 (comment)
git-phu
force-pushed
the
peter/list-private-definitions
branch
from
a11e3ba to
bab7631
Compare
This was referenced Mar 24, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #9652
Tech Spec
Implements routes to list all private, non-custom definitions, and for each indicate whether the given workspace has a grant for using the definition. Used by admins to view and modify a given workspace's grants.
Depends on #11305 and #11336
Recommended reading order
Easiest to view by commit
User Impact
Doesn't change the behavior of existing routes