Skip to content

Rename jdbc db methods that require manual closure #11300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2022
Merged

Rename jdbc db methods that require manual closure #11300

merged 2 commits into from
Mar 21, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Mar 21, 2022 •
edited
Loading

Summary

  • This relates to [EPIC] Fix database connection leak #10386.
  • A few methods in JdbcDatabase is not safe because the returned streams need to be closed manually, otherwise there will be database connection leaks.
  • This PR renames those methods to make this issue more visible.

Review order

  • The only real changes are all in JdbcDatabase.java.

@tuliren tuliren temporarily deployed to more-secrets March 21, 2022 20:44 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Mar 21, 2022
@tuliren tuliren merged commit e5ae3b3 into master Mar 21, 2022
@tuliren tuliren deleted the liren/update-jdbc-database branch March 21, 2022 22:00
This was referenced Mar 23, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

@ChristopheDuong ChristopheDuong Awaiting requested review from ChristopheDuong

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuliren @edgao