Skip to content

🐛 Fix Intercom stream base url in check connection #11176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2022
Merged

🐛 Fix Intercom stream base url in check connection #11176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fff2fb
[Bug fix] Intercom stream base url
mrhallak Mar 15, 2022
b985a54
Merge branch 'airbytehq:master' into mrhallak/fix-intercom-stream-bas…
mrhallak Mar 18, 2022
ec92ab6
Restore backslash and use urljoin
mrhallak Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-intercom/source_intercom/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@


class IntercomStream(HttpStream, ABC):
url_base = "https://api.intercom.io/"
url_base = "https://api.intercom.io"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is concatenated with stream paths below to form https://api.intercom.io/<path> -- is it safe to do this?

Copy link
Member

@marcosmarxm marcosmarxm Mar 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reading stream data doesn't matter urljoin will parse correctly with / or without.

The problem happens in the check connection function where is concatenating using f-string and not urljoin.

airbyte/airbyte-integrations/connectors/source-intercom/source_intercom/source.py

Lines 416 to 417 in 266a491

url = f"{IntercomStream.url_base}/tags"
auth_headers = {"Accept": "application/json", **authenticator.get_auth_header()}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherifnada @marcosmarxm Would you guys prefer it if I change it to a urljoin?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be better imo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!


primary_key = "id"
data_fields = ["data"]
Expand Down