Skip to content

🐛 octavia-cli: do not use deepcopy in _get_comparable_configuration #11000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Mar 9, 2022

Running deep copy on SourceRead / DestinationRead object does not work leading to errors such as:

TypeError: _from_openapi_data() missing 6 required positional arguments: 'source_definition_id', 'source_id', 'workspace_id', 'connection_configuration', 'name', and 'source_name'

deepcopy does not call the constructor as expected. Rather than defining a custom deepcopy hook, I prefer to discard its usage and prefer to create a new dict rather than mutating it.

@alafanechere alafanechere changed the title 🐛 octavia-cli: do not use deepcopy in _get_comparable_config 🐛 octavia-cli: do not use deepcopy in _get_comparable_configuration Mar 9, 2022
@alafanechere alafanechere temporarily deployed to more-secrets March 9, 2022 21:57 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 9, 2022 21:57 Inactive
@alafanechere alafanechere added area/octavia-cli type/bug Something isn't working labels Mar 9, 2022
@alafanechere alafanechere requested a review from marcosmarxm March 9, 2022 22:00
@alafanechere alafanechere merged commit 8c3b5fc into master Mar 9, 2022
@alafanechere alafanechere deleted the augustin/octavia-cli/fix-apply branch March 9, 2022 22:38
@alafanechere alafanechere added this to the octavia-cli-alpha milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants