Skip to content

Fix unit test failures from env configs #10998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 9, 2022
Merged

Fix unit test failures from env configs #10998

merged 5 commits into from
Mar 9, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Mar 9, 2022

@tuliren tuliren requested a review from benmoriceau March 9, 2022 21:35
@tuliren tuliren temporarily deployed to more-secrets March 9, 2022 21:36 Inactive
@tuliren tuliren temporarily deployed to more-secrets March 9, 2022 21:36 Inactive
benmoriceau
benmoriceau reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@benmoriceau benmoriceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to build when the build is passing

@tuliren tuliren temporarily deployed to more-secrets March 9, 2022 21:49 Inactive
@tuliren tuliren temporarily deployed to more-secrets March 9, 2022 21:49 Inactive
@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Mar 9, 2022
@tuliren tuliren temporarily deployed to more-secrets March 9, 2022 22:01 Inactive
@tuliren tuliren temporarily deployed to more-secrets March 9, 2022 22:01 Inactive
@tuliren tuliren temporarily deployed to more-secrets March 9, 2022 22:03 Inactive
@tuliren tuliren temporarily deployed to more-secrets March 9, 2022 22:03 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Mar 9, 2022 •
edited
Loading

The remaining failure is transient due to network issue:

Execution failed for task ':buildDockerImage-webapp'.
> Could not build image: Get https://registry-1.docker.io/v2/library/nginx/manifests/sha256:07ab71a2c8e4ecb19a5a5***fb3a4f175946c001c8af288b1aa766d67b0d05d2: dial tcp: lookup registry-1.docker.io: Temporary failure in name resolution

@tuliren tuliren merged commit f574899 into master Mar 9, 2022
@tuliren tuliren deleted the liren/fix-unit-test branch March 9, 2022 22:24
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau left review comments

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuliren @benmoriceau