Skip to content

🐙 octavia-cli: secret management #10885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 9, 2022
Merged

🐙 octavia-cli: secret management #10885

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69e4eba
🐙 octavia-cli: implement secrement management
alafanechere Mar 6, 2022
2ddd13c
Merge branch 'master' into augustin/octavia-cli/secret-management
alafanechere Mar 9, 2022
d828d01
fix other conflicts
alafanechere Mar 9, 2022
64b47c6
Merge branch 'master' into augustin/octavia-cli/secret-management
alafanechere Mar 9, 2022
e58f535
fix brutal search and replace error
alafanechere Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...a-cli/integration_tests/test_generate/expected_rendered_yaml/destination_s3/expected.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ configuration:
## -------- Another valid structure for compression_codec: --------
# codec: "zstandard" # REQUIRED | string
# compression_level: 3 # REQUIRED | integer | Negative levels are 'fast' modes akin to lz4 or snappy, levels above 9 are generally for archival purposes, and levels above 18 use a lot of memory.
# include_hash: # OPTIONAL | boolean | If true, include a hash with each data block.
# include_checksum: # OPTIONAL | boolean | If true, include a checksum with each data block.
## -------- Another valid structure for compression_codec: --------
# codec: "snappy" # REQUIRED | string
part_size_mb: 5 # OPTIONAL | integer | This is the size of a "Part" being buffered in memory. It limits the memory usage when writing. Larger values will allow to upload a bigger files and improve the speed, but consumes9 more memory. Allowed values: min=5MB, max=525MB Default: 5MB. | Example: 5
Expand Down
6 changes: 3 additions & 3 deletions ...cli/integration_tests/test_generate/expected_rendered_yaml/destination_s3/input_spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ spec:
default: 3
minimum: -5
maximum: 22
include_hash:
title: "Include hash"
description: "If true, include a hash with each data block."
include_checksum:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alafanechere are you chancing to checksum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the original field name for this S3 destination connector was include_checksum. I mistakenly renamed it to include_hash while doing a brutal search and replace it when renaming other code occurrences of checksum to hash.

title: "Include checksum"
description: "If true, include a checksum with each data block."
type: "boolean"
default: false
- title: "snappy"
Expand Down